fix(tier4_perception_launch): update multi-channel subscribing channel name to lidar_detection_model_type #9624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The object detection channels in the `tracking.launch.xml` file have been updated to include the lidar detection model type. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yukkysaito
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
@YoshiRi The change itself looks good, but I haven’t been able to check the coding style or detailed logic. Could I ask you to review those?
YoshiRi
requested changes
Dec 12, 2024
launch/tier4_perception_launch/launch/object_recognition/tracking/tracking.launch.xml
Outdated
Show resolved
Hide resolved
YoshiRi
reviewed
Dec 12, 2024
launch/tier4_perception_launch/launch/object_recognition/tracking/tracking.launch.xml
Outdated
Show resolved
Hide resolved
add variable use_validator to the tracking launch and determine the subscribing channel depends on the use_validator value Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The object detection channels in the
tracking.launch.xmlfile have been updated to use the lidar detection model type.Implementing changes by PR #9003
This PR do not contain logic change.
Related links
Parent Issue:
How was this PR tested?
set parameters as following
use_multi_channel_tracker_mergertruelidar_detection_modelcenterpoint/centerpoint_tinyNotes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.