Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(crop_box_filter): crop_box_filter_without_pcl #951

Merged
merged 1 commit into from
May 25, 2022
Merged

fix(crop_box_filter): crop_box_filter_without_pcl #951

merged 1 commit into from
May 25, 2022

Conversation

plane-li
Copy link
Contributor

@plane-li plane-li commented May 24, 2022 •
edited
Loading

Signed-off-by: plane.li plane.li@autocore.ai

Description

The pr is to fix the "crop_box_filter node "which can cause error in the subsequent module.
related issue: #705

It is an other pr to solve the problem without using pcl.

Related links

#705

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@plane-li plane-li requested a review from Sharrrrk May 24, 2022 02:43
@plane-li plane-li mentioned this pull request May 24, 2022
Closed
4 tasks
@plane-li plane-li changed the title fix: crop_box_filter_without_pcl fix(crop_box_filter): crop_box_filter_without_pcl May 24, 2022
@wep21 wep21 force-pushed the issue_#705_fix_crop_box_filter_without_pcl branch from be0cf02 to 6d271f6 Compare May 24, 2022 11:57
@wep21 wep21 added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label May 24, 2022
@plane-li
fix(crop_box_filter): crop_box_filter_without_pcl
0ea87d9 
Signed-off-by: plane.li <plane.li@autocore.ai>
@wep21 wep21 force-pushed the issue_#705_fix_crop_box_filter_without_pcl branch from 6d271f6 to 0ea87d9 Compare May 24, 2022 12:02
@codecov
Copy link

codecov bot commented May 24, 2022 •
edited
Loading

Codecov Report

Merging #951 (6d271f6) into main (0f430f1) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 6d271f6 differs from pull request most recent head 0ea87d9. Consider uploading reports for the commit 0ea87d9 to get more accurate results

@@          Coverage Diff          @@
##            main    #951   +/-   ##
=====================================
  Coverage   9.90%   9.90%           
=====================================
  Files        879     879           
  Lines      56251   56251           
  Branches   10638   10638           
=====================================
  Hits        5570    5570           
  Misses     45962   45962           
  Partials    4719    4719
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.90% <0.00%> (ø) Carriedforward from 0f430f1

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or/src/crop_box_filter/crop_box_filter_nodelet.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f430f1...0ea87d9. Read the comment docs.

@wep21 wep21 self-requested a review May 24, 2022 21:31
wep21
wep21 approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine even when input->height doesn't equal to 1.

@wep21 wep21 requested a review from mitsudome-r May 25, 2022 01:50
@plane-li
Copy link
Contributor Author

It works fine even when input->height doesn't equal to 1.

The crop_box_filter is useful.However it can cause error in the subsequent nodes such as down_sample,ground_filter.
More detail info:
#705
#881

@wep21 wep21 merged commit 641a29e into autowarefoundation:main May 25, 2022
@wep21
Copy link
Contributor

wep21 commented May 25, 2022

@plane-li Thank you for your contribution.

@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request May 26, 2022
Merged
@plane-li plane-li deleted the issue_#705_fix_crop_box_filter_without_pcl branch May 30, 2022 05:29
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Jun 7, 2022
@plane-li @ktro2828
fix(crop_box_filter): crop_box_filter_without_pcl (autowarefoundation…
1fd91e6 
…#951)

Signed-off-by: plane.li <plane.li@autocore.ai>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@mitsudome-r mitsudome-r mentioned this pull request Jun 21, 2022
Closed
3 tasks
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@plane-li @boyali
fix(crop_box_filter): crop_box_filter_without_pcl (tier4#951)
831da20 
Signed-off-by: plane.li <plane.li@autocore.ai>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@plane-li @boyali
fix(crop_box_filter): crop_box_filter_without_pcl (tier4#951)
4db7faf 
Signed-off-by: plane.li <plane.li@autocore.ai>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@plane-li @boyali
fix(crop_box_filter): crop_box_filter_without_pcl (tier4#951)
3b202c0 
Signed-off-by: plane.li <plane.li@autocore.ai>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@plane-li @boyali
fix(crop_box_filter): crop_box_filter_without_pcl (tier4#951)
e1ce3a1 
Signed-off-by: plane.li <plane.li@autocore.ai>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Oct 17, 2023
@TakaHoribe
fix(mpc): use optimization result when polish failed (autowarefoundat…
40c87d2 
…ion#4673) (autowarefoundation#951)

* fix(mpc): use optimization result when polish failed



* fix arg



---------

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
@satoshi-ota
refactor(avoidance, AbLC): rebuild parameter structure (autowarefound…
727ca26 
…ation#951)

* refactor(avoidance): update yaml

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(AbLC): update yaml

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@wep21 wep21 wep21 approved these changes

@Sharrrrk Sharrrrk Awaiting requested review from Sharrrrk

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

Assignees
No one assigned
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plane-li @wep21 @yukkysaito