Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing namespaces in C++ code #9477

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: fix missing namespaces in C++ code #9477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/autoware_component_interface_tools/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ament_auto_add_library(${PROJECT_NAME} SHARED
)

rclcpp_components_register_node(${PROJECT_NAME}
PLUGIN "ServiceLogChecker"
PLUGIN "autoware::component_interface_tools::ServiceLogChecker"
EXECUTABLE service_log_checker_node
)

Expand Down
6 changes: 4 additions & 2 deletions common/autoware_component_interface_tools/src/service_log_checker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
#define FMT_HEADER_ONLY
#include <fmt/format.h>

namespace autoware::component_interface_tools
{
ServiceLogChecker::ServiceLogChecker(const rclcpp::NodeOptions & options)
: Node("service_log_checker", options), diagnostics_(this)
{
Expand Down Expand Up @@ -98,6 +100,6 @@
stat.summary(DiagnosticStatus::ERROR, "ERROR");
}
}

} // namespace autoware::component_interface_tools
#include <rclcpp_components/register_node_macro.hpp>
RCLCPP_COMPONENTS_REGISTER_NODE(ServiceLogChecker)
RCLCPP_COMPONENTS_REGISTER_NODE(autoware::component_interface_tools::ServiceLogChecker)

Check warning on line 105 in common/autoware_component_interface_tools/src/service_log_checker.cpp

View check run for this annotation

Codecov / codecov/patch

common/autoware_component_interface_tools/src/service_log_checker.cpp#L105 

Added line #L105 was not covered by tests
4 changes: 3 additions & 1 deletion common/autoware_component_interface_tools/src/service_log_checker.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
#include <string>
#include <unordered_map>

namespace autoware::component_interface_tools
{
class ServiceLogChecker : public rclcpp::Node
{
public:
Expand All @@ -38,5 +40,5 @@ class ServiceLogChecker : public rclcpp::Node
void update_diagnostics(diagnostic_updater::DiagnosticStatusWrapper & stat);
std::unordered_map<std::string, std::string> errors_;
};

} // namespace autoware::component_interface_tools
#endif // SERVICE_LOG_CHECKER_HPP_
2 changes: 1 addition & 1 deletion common/autoware_traffic_light_recognition_marker_publisher/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ament_auto_add_library(${PROJECT_NAME} SHARED
)

rclcpp_components_register_node(${PROJECT_NAME}
PLUGIN "TrafficLightRecognitionMarkerPublisher"
PLUGIN "autoware::traffic_light_recognition_marker_publisher::TrafficLightRecognitionMarkerPublisher"
EXECUTABLE ${PROJECT_NAME}_node
)

Expand Down
6 changes: 5 additions & 1 deletion ...fic_light_recognition_marker_publisher/src/traffic_light_recognition_marker_publisher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
#include <utility>
#include <vector>

namespace autoware::traffic_light_recognition_marker_publisher
{
TrafficLightRecognitionMarkerPublisher::TrafficLightRecognitionMarkerPublisher(
const rclcpp::NodeOptions & options)
: Node("traffic_light_recognition_marker_publisher", options)
Expand Down Expand Up @@ -159,6 +161,8 @@

return c; // white
}
} // namespace autoware::traffic_light_recognition_marker_publisher

#include <rclcpp_components/register_node_macro.hpp>
RCLCPP_COMPONENTS_REGISTER_NODE(TrafficLightRecognitionMarkerPublisher)
RCLCPP_COMPONENTS_REGISTER_NODE(

Check warning on line 167 in common/autoware_traffic_light_recognition_marker_publisher/src/traffic_light_recognition_marker_publisher.cpp

View check run for this annotation

Codecov / codecov/patch

common/autoware_traffic_light_recognition_marker_publisher/src/traffic_light_recognition_marker_publisher.cpp#L167 

Added line #L167 was not covered by tests
autoware::traffic_light_recognition_marker_publisher::TrafficLightRecognitionMarkerPublisher)
3 changes: 3 additions & 0 deletions ...fic_light_recognition_marker_publisher/src/traffic_light_recognition_marker_publisher.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
#include <map>
#include <string>

namespace autoware::traffic_light_recognition_marker_publisher
{
class TrafficLightRecognitionMarkerPublisher : public rclcpp::Node
{
public:
Expand Down Expand Up @@ -58,5 +60,6 @@ class TrafficLightRecognitionMarkerPublisher : public rclcpp::Node
bool is_map_ready_ = false;
int32_t marker_id = 0;
};
} // namespace autoware::traffic_light_recognition_marker_publisher

#endif // TRAFFIC_LIGHT_RECOGNITION_MARKER_PUBLISHER_HPP_
Loading