Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_traffic_light_visualization): include opencv as system #9331

Conversation

yhisaki
Copy link
Contributor

@yhisaki yhisaki commented Nov 15, 2024

Description

To suppress the following error from clang-tidy, we include opencv as a system header.

Error while processing /home/hisaki/workspace/clang-tidy-ci/autoware/src/universe/autoware.universe/perception/autoware_traffic_light_visualization/src/traffic_light_roi_visualizer/shape_draw.cpp.
/usr/include/opencv4/opencv2/core/cuda.inl.hpp:105:9: error: '_Atomic' is a C11 extension [clang-diagnostic-c11-extensions]
        CV_XADD(refcount, 1);
        ^
/usr/include/opencv4/opencv2/core/cvdef.h:670:60: note: expanded from macro 'CV_XADD'
#      define CV_XADD(addr, delta) __c11_atomic_fetch_add((_Atomic(int)*)(addr), delta, __ATOMIC_ACQ_REL)
                                                           ^
/usr/include/opencv4/opencv2/core/cuda.inl.hpp:487:9: error: '_Atomic' is a C11 extension [clang-diagnostic-c11-extensions]
        CV_XADD(refcount, 1);
        ^
/usr/include/opencv4/opencv2/core/cvdef.h:670:60: note: expanded from macro 'CV_XADD'
#      define CV_XADD(addr, delta) __c11_atomic_fetch_add((_Atomic(int)*)(addr), delta, __ATOMIC_ACQ_REL)
                                                           ^
/usr/include/opencv4/opencv2/core/mat.inl.hpp:2116:9: error: '_Atomic' is a C11 extension [clang-diagnostic-c11-extensions]
        CV_XADD(&this->hdr->refcount, 1);
        ^
/usr/include/opencv4/opencv2/core/cvdef.h:670:60: note: expanded from macro 'CV_XADD'
#      define CV_XADD(addr, delta) __c11_atomic_fetch_add((_Atomic(int)*)(addr), delta, __ATOMIC_ACQ_REL)
                                                           ^
/usr/include/opencv4/opencv2/core/mat.inl.hpp:2131:21: error: '_Atomic' is a C11 extension [clang-diagnostic-c11-extensions]
        if( m.hdr ) CV_XADD(&m.hdr->refcount, 1);
                    ^
/usr/include/opencv4/opencv2/core/cvdef.h:670:60: note: expanded from macro 'CV_XADD'
#      define CV_XADD(addr, delta) __c11_atomic_fetch_add((_Atomic(int)*)(addr), delta, __ATOMIC_ACQ_REL)
                                                           ^
/usr/include/opencv4/opencv2/flann/index_testing.h:249:11: error: variable 'p1' set but not used [clang-diagnostic-unused-but-set-variable]
    float p1;

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Nov 15, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yhisaki yhisaki marked this pull request as ready for review November 15, 2024 08:35
@yhisaki yhisaki added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 15, 2024
@yhisaki yhisaki enabled auto-merge (squash) November 15, 2024 08:35
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.80%. Comparing base (e54020e) to head (a724d61).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9331   +/-   ##
=======================================
  Coverage   29.80%   29.80%           
=======================================
  Files        1338     1338           
  Lines      103208   103208           
  Branches    40216    40216           
=======================================
  Hits        30757    30757           
  Misses      69467    69467           
  Partials     2984     2984           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 29.80% <ø> (ø) Carriedforward from e54020e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhisaki yhisaki merged commit 08951b2 into autowarefoundation:main Nov 17, 2024
42 checks passed
@yhisaki yhisaki deleted the modify-cmake-traffic_light_visualization branch November 18, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants