Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): use vehicle side edge to check isCrossingPossible for pull over execution #9102

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 17, 2024

Description

Get the lanelet of the ego vehicle's side edge at the terminal pose of the previous module's path. Check if the lane is the target lane or the neighboring lane. NOTE: This is because in the case of avoidance, there is a possibility of base_link entering the neighboring lane, and we want to activate the pull over at this time as well.

before (stuck without pull over)

image

after

lc_avoid_goal-2024-10-17_15.43.04.mp4

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 17, 2024
Copy link

github-actions bot commented Oct 17, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 27.53%. Comparing base (6ff2121) to head (857afd6).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9102      +/-   ##
==========================================
- Coverage   27.55%   27.53%   -0.02%     
==========================================
  Files        1304     1307       +3     
  Lines      101047   101054       +7     
  Branches    39236    39216      -20     
==========================================
- Hits        27843    27829      -14     
- Misses      70580    70594      +14     
- Partials     2624     2631       +7     
Flag Coverage Δ *Carryforward flag
differential 1.24% <0.00%> (?)
total 27.55% <ø> (+<0.01%) ⬆️ Carriedforward from 6ff2121

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… for pull over execution

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the fix/avoidance_pull_over branch from 96b3e33 to 857afd6 Compare October 21, 2024 02:55
@kosuke55 kosuke55 merged commit 06adbc4 into autowarefoundation:main Oct 21, 2024
34 of 36 checks passed
@kosuke55 kosuke55 deleted the fix/avoidance_pull_over branch October 21, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants