-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(motion_utils): add test for path shift #9083
test(motion_utils): add test for path shift #9083
Conversation
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
#ifndef AUTOWARE__MOTION_UTILS__TRAJECTORY__PATH_SHIFT_HPP_ | ||
#define AUTOWARE__MOTION_UTILS__TRAJECTORY__PATH_SHIFT_HPP_ | ||
|
||
#include <cmath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(minor) this include seems unnecessary.
#include <cmath> |
Maybe it should be included in the cpp file instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted in eefab5f, and rebased this PR. Could you approve the preceding PR too?
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
688f855
to
b78c2e5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9083 +/- ##
==========================================
+ Coverage 27.09% 27.19% +0.10%
==========================================
Files 1300 1304 +4
Lines 95810 96037 +227
Branches 39122 39156 +34
==========================================
+ Hits 25955 26115 +160
- Misses 67257 67310 +53
- Partials 2598 2612 +14
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* remove unused function Signed-off-by: Go Sakayori <gsakayori@gmail.com> * mover path shifter utils function to autoware motion utils Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> * minor change in license header Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> * fix warning message Signed-off-by: Go Sakayori <gsakayori@gmail.com> * remove header file Signed-off-by: Go Sakayori <gsakayori@gmail.com> * add test file Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> * add unit test to all function Signed-off-by: Go Sakayori <gsakayori@gmail.com> * fix spelling Signed-off-by: Go Sakayori <gsakayori@gmail.com> --------- Signed-off-by: Go Sakayori <gsakayori@gmail.com> Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
Description
Add unit test for
![image](https://private-user-images.githubusercontent.com/12757369/375961127-02b9d886-92b7-49d4-872b-669cd659397c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMjAwMTIsIm5iZiI6MTczOTMxOTcxMiwicGF0aCI6Ii8xMjc1NzM2OS8zNzU5NjExMjctMDJiOWQ4ODYtOTJiNy00OWQ0LTg3MmItNjY5Y2Q2NTkzOTdjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDAwMjE1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUzNjg3ZmUwZjI4MWZlMmUzZTIyOWMyYzQ5MjkyNWE0ZGRlZjc4NDI5MTYxZDg3MGIwN2RkYjI4OGMwYWYwMDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4GuiJsfzRwANXxiioIBnmTSsJFL1hthDz2bHeyUkbus)
motion_utils/path shift.cpp
.Related links
#9081
How was this PR tested?
Colcon test
Notes for reviewers
Includes changes from preceding PR. Please review the preceding PR first.
Interface changes
None.
Effects on system behavior
None.