Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(no_stopping_area): refactor and add tests #9009

Merged
merged 15 commits into from
Oct 15, 2024
Merged

test(no_stopping_area): refactor and add tests #9009

merged 15 commits into from
Oct 15, 2024

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Oct 2, 2024 •
edited
Loading

Description

Refactor the no_stopping_area module to make it easier to test and add unit tests.

Related links

Private Links:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem maxime-clem force-pushed the test/no_stopping_area branch from e2f1297 to 2147877 Compare October 3, 2024 04:14
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 3, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.04348% with 31 lines in your changes missing coverage. Please review.

Project coverage is 26.78%. Comparing base (872ddb3) to head (8b84900).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
...topping_area_module/src/scene_no_stopping_area.cpp 0.00% 17 Missing ⚠️
...ior_velocity_no_stopping_area_module/src/utils.cpp 91.20% 0 Missing and 8 partials ⚠️
...ior_velocity_no_stopping_area_module/src/utils.hpp 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9009      +/-   ##
==========================================
+ Coverage   26.66%   26.78%   +0.11%     
==========================================
  Files        1296     1302       +6     
  Lines       95691    95715      +24     
  Branches    39092    39081      -11     
==========================================
+ Hits        25516    25635     +119     
+ Misses      67601    67431     -170     
- Partials     2574     2649      +75
Flag Coverage Δ *Carryforward flag
differential 21.07% <73.04%> (?)
total 26.70% <ø> (+0.03%) ⬆️ Carriedforward from ff8ee64

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem changed the title Test/no stopping area test(no_stopping_area): refactor and add tests Oct 4, 2024
@maxime-clem maxime-clem force-pushed the test/no_stopping_area branch from 32aa3ed to 5168167 Compare October 7, 2024 04:52
@github-actions github-actions bot removed the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Oct 7, 2024
@maxime-clem
refactoring to make testing easier
6039027 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
more refactoring
e2ae895 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
[DEBUG] run bvp in gdb+konsole
2b26a00 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
more refactoring
08384a0 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
add first test (is_vehicle_type)
1f4d0cf 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
add test for insert_stop_point
d6f8172 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
add test for generate_stop_line
694a5ca 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
refactor and add test for is_stoppable()
9cae17b 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
cleanup dependencies in package.xml and add Maxime as maintainer
523ef81 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
refactor and add test for generate_ego_no_stopping_area_lane_polygons
ae82e74 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
refactor and add test for check_stop_lines_in_no_stopping_area
9426f04 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
update docstrings and add test for get_stop_line_geometry_2d
7c4fa86 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
disable failing checks for checkStopLinesInNoStoppingArea (need fix)
8548c86 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
Revert "[DEBUG] run bvp in gdb+konsole"
ff8ee64 
This reverts commit 1927b1e.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the test/no_stopping_area branch from 5168167 to ff8ee64 Compare October 7, 2024 06:30
@maxime-clem maxime-clem marked this pull request as ready for review October 7, 2024 06:37
@maxime-clem maxime-clem requested a review from kosuke55 as a code owner October 7, 2024 06:37
@maxime-clem @kosuke55
Fix docstring (minimum -> maximum)
8b84900 
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
@maxime-clem maxime-clem merged commit 0de8669 into autowarefoundation:main Oct 15, 2024
30 of 32 checks passed
@maxime-clem maxime-clem deleted the test/no_stopping_area branch October 15, 2024 01:32
@maxime-clem maxime-clem restored the test/no_stopping_area branch October 15, 2024 01:33
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 16, 2024
@maxime-clem @kosuke55 @prakash-kannaiah
test(no_stopping_area): refactor and add tests (autowarefoundation#9009)
cf473fb 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soblin soblin soblin approved these changes

@kosuke55 kosuke55 kosuke55 approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi isamu-takagi is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxime-clem @soblin @kosuke55