Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_state_rviz_plugin): fix unmatchedSuppression #8921

Merged

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck unmatchedSuppression warnings.
Due to a modification to cppcheck's CI, comment suppression is no longer required for items that previously generated warnings.

common/tier4_state_rviz_plugin/src/custom_button.cpp:67:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomElevatedButton::updateStyle(
^
common/tier4_state_rviz_plugin/src/custom_container.cpp:30:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
QGridLayout * CustomContainer::getLayout() const
^
common/tier4_state_rviz_plugin/src/custom_segmented_button.cpp:44:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
QButtonGroup * CustomSegmentedButton::getButtonGroup() const
^
common/tier4_state_rviz_plugin/src/custom_segmented_button_item.cpp:48:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomSegmentedButtonItem::setHovered(bool hovered)
^
common/tier4_state_rviz_plugin/src/custom_segmented_button_item.cpp:55:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomSegmentedButtonItem::setCheckableButton(bool checkable)
^
common/tier4_state_rviz_plugin/src/custom_segmented_button_item.cpp:70:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomSegmentedButtonItem::setDisabledButton(bool disabled)
^
common/tier4_state_rviz_plugin/src/custom_segmented_button_item.cpp:77:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomSegmentedButtonItem::setActivated(bool activated)
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 requested a review from veqcc September 19, 2024 07:08
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Sep 19, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.92%. Comparing base (03ecd6e) to head (90da640).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8921      +/-   ##
==========================================
- Coverage   27.98%   27.92%   -0.06%     
==========================================
  Files        1319     1319              
  Lines       98729    98671      -58     
  Branches    39809    39762      -47     
==========================================
- Hits        27631    27558      -73     
- Misses      71066    71080      +14     
- Partials       32       33       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 27.93% <ø> (-0.06%) ⬇️ Carriedforward from 03ecd6e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858
Copy link
Contributor Author

@h-ohta @isamu-takagi @KhalilSelyan

Please confirm the PR. Thank you very much.

@kobayu858 kobayu858 merged commit c40efa2 into autowarefoundation:main Sep 24, 2024
42 checks passed
@kobayu858 kobayu858 deleted the fix/cppcheck_addWarning_com-s7 branch October 1, 2024 08:09
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
…ation#8921)

fix:unmatchedSuppression

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants