Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(emergency_handler): delete package #8917

Merged
merged 3 commits into from
Sep 20, 2024
Merged

feat(emergency_handler): delete package #8917

merged 3 commits into from
Sep 20, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Sep 19, 2024 •
edited
Loading

Description

Delete emergency_handler package

Related links

Discussion: https://github.com/orgs/autowarefoundation/discussions/4176
PR for autoware_launch: autowarefoundation/autoware_launch#1173

How was this PR tested?

  • Psim
  • Lsim

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@veqcc
feat(emergency_handler): delete package
ab8d033 
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Sep 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc mentioned this pull request Sep 19, 2024
Merged
4 tasks
@mkuri
Copy link
Contributor

mkuri commented Sep 19, 2024

It is a minor detail, but it would be better to change the svg of system_launch as well.

https://github.com/autowarefoundation/autoware.universe/blob/main/launch/tier4_system_launch/system_launch.drawio.svg

@veqcc
fix hazard_status_converter
f2f69fc 
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@veqcc
fix svg
93404de 
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@veqcc
Copy link
Contributor Author

veqcc commented Sep 19, 2024

@mkuri
I have update the svg (from emergency_handler to mrm_handler) 93404de

@mkuri mkuri self-requested a review September 19, 2024 08:26
mkuri
mkuri approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veqcc veqcc self-assigned this Sep 19, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 19, 2024
@veqcc
Copy link
Contributor Author

veqcc commented Sep 20, 2024

@ito-san
Hi, could you review it? It needs your approval 🙏

TetsuKawa
TetsuKawa approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@TetsuKawa TetsuKawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veqcc veqcc merged commit 583d856 into autowarefoundation:main Sep 20, 2024
35 of 36 checks passed
@veqcc veqcc deleted the feat/delete_emergency_handler branch September 20, 2024 05:16
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 20, 2024
@veqcc @rej55
feat(emergency_handler): delete package (autowarefoundation#8917)
05acc9e 
* feat(emergency_handler): delete package

Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
@rej55 rej55 mentioned this pull request Sep 20, 2024
Merged
rej55 added a commit to tier4/autoware.universe that referenced this pull request Sep 20, 2024
@rej55
Merge pull request #1549 from tier4/feat/delete_emergency_handler
0eb2e35 
feat(emergency_handler): delete package (autowarefoundation#8917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuri mkuri mkuri approved these changes

@TetsuKawa TetsuKawa TetsuKawa approved these changes

@ito-san ito-san Awaiting requested review from ito-san ito-san is a code owner

Assignees

@veqcc veqcc

Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veqcc @mkuri @TetsuKawa