Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update rviz plugin icons to match the theme #8868

Merged

Conversation

KhalilSelyan
Copy link
Contributor

Description

Updated icon colors on the toolbuttons to match the theme

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@KhalilSelyan KhalilSelyan self-assigned this Sep 12, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels Sep 12, 2024
Copy link

github-actions bot commented Sep 12, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yukkysaito
Copy link
Contributor

Cloud you share the screen shot of new theme?

@yukkysaito
Copy link
Contributor

By the way, this icon might work well for people who have switched to Ubuntu’s dark theme, but wouldn't it be hard to see for those using the default theme?

@xmfcx xmfcx marked this pull request as draft September 12, 2024 15:01
@yukkysaito
Copy link
Contributor

By the way, this icon might work well for people who have switched to Ubuntu’s dark theme, but wouldn't it be hard to see for those using the default theme?

I see 👍
You are in the process of changing it to default to dark theme
autowarefoundation/autoware#4534

@xmfcx xmfcx force-pushed the style/update-toolbutton-icons branch from 6350b24 to 6d6b414 Compare September 12, 2024 15:13
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
@xmfcx xmfcx force-pushed the style/update-toolbutton-icons branch from 6d6b414 to 51a398d Compare September 17, 2024 14:48
@xmfcx
Copy link
Contributor

xmfcx commented Sep 17, 2024

image

@yukkysaito the new icons are still readable under the default theme. It has low contrast but it is alright.

@KhalilSelyan these 2 need to be updated from the tools.repos:
image
tier4_automatic_goal_rviz_plugin

Edit: Sorry you've already created a pr:

@xmfcx
Copy link
Contributor

xmfcx commented Sep 17, 2024

image

Also they should be 20px by 20px and have the same shapes. Bird icon got broken due to difference in line width/style.

@xmfcx
Copy link
Contributor

xmfcx commented Sep 18, 2024

This is how they were initially generated, I've updated the colors:

Edit: Updated again for smaller outputs.
Now it will download as 64x64 px

@KhalilSelyan
Copy link
Contributor Author

This is how they were initially generated, I've updated the colors:

I used the same links, but they provide bigger icons now for some reason ? should i use some online resizer or something for them ?

@KhalilSelyan KhalilSelyan changed the title update icons to match theme style: update icons to match theme Sep 18, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Sep 18, 2024

I've updated the links again.
#8868 (comment)

could you replace the images with these? 64x64 is alright. But styles will match the old ones now.
especially the raven looks normal now.

20x20 px was too small anyways, in rviz it is occupying 30x30 px space.

@xmfcx
Copy link
Contributor

xmfcx commented Sep 18, 2024

Ideal solution would be to just have the svg icons in the source folder and have custom cmake command to call a python script to color and generate png in the install folder at compile time.

But it would be too much work for just a couple kilobytes.

Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
@KhalilSelyan KhalilSelyan changed the title style: update icons to match theme style: update rviz plugin icons to match the theme Sep 18, 2024
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 18, 2024
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@xmfcx xmfcx marked this pull request as ready for review September 18, 2024 11:59
@xmfcx xmfcx merged commit 1ebc3dc into autowarefoundation:main Sep 18, 2024
38 checks passed
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.00%. Comparing base (28a389b) to head (ebb8304).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8868   +/-   ##
=======================================
  Coverage   28.00%   28.00%           
=======================================
  Files        1319     1319           
  Lines       98699    98699           
  Branches    39787    39787           
=======================================
  Hits        27641    27641           
  Misses      70989    70989           
  Partials       69       69           
Flag Coverage Δ *Carryforward flag
total 28.00% <ø> (ø) Carriedforward from 28a389b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants