-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: update rviz plugin icons to match the theme #8868
style: update rviz plugin icons to match the theme #8868
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Cloud you share the screen shot of new theme? |
By the way, this icon might work well for people who have switched to Ubuntu’s dark theme, but wouldn't it be hard to see for those using the default theme? |
I see 👍 |
6350b24
to
6d6b414
Compare
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
6d6b414
to
51a398d
Compare
@yukkysaito the new icons are still readable under the default theme. It has low contrast but it is alright.
Edit: Sorry you've already created a pr: |
This is how they were initially generated, I've updated the colors:
Edit: Updated again for smaller outputs. |
I used the same links, but they provide bigger icons now for some reason ? should i use some online resizer or something for them ? |
I've updated the links again. could you replace the images with these? 64x64 is alright. But styles will match the old ones now. 20x20 px was too small anyways, in rviz it is occupying 30x30 px space. |
Ideal solution would be to just have the svg icons in the source folder and have custom cmake command to call a python script to color and generate png in the install folder at compile time. But it would be too much work for just a couple kilobytes. |
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8868 +/- ##
=======================================
Coverage 28.00% 28.00%
=======================================
Files 1319 1319
Lines 98699 98699
Branches 39787 39787
=======================================
Hits 27641 27641
Misses 70989 70989
Partials 69 69
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Updated icon colors on the toolbuttons to match the theme
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.