Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pose_initializer)!: prefix package and namespace with autoware #8701

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Sep 2, 2024

Description

This PR will add an autoware_ prefix to pose_initializer package.

Also directory structure is changed to fit https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#include-and-src

Related links

Parent Issue:

How was this PR tested?

Checked that it works with the Autoware's sample ROS bag.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 2, 2024
@SakodaShintaro
Copy link
Contributor

@a-maumau
One of the CI checks failed: 'pre-commit-optional'.
Can you please take a look?

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 24.07%. Comparing base (544b06e) to head (0afd22e).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...are_pose_initializer/src/pose_initializer_core.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8701      +/-   ##
==========================================
- Coverage   24.13%   24.07%   -0.06%     
==========================================
  Files        1400     1412      +12     
  Lines      102258   102514     +256     
  Branches    38763    38799      +36     
==========================================
+ Hits        24679    24684       +5     
- Misses      75086    75337     +251     
  Partials     2493     2493              
Flag Coverage Δ *Carryforward flag
differential 0.14% <0.00%> (?)
total 24.13% <ø> (ø) Carriedforward from ea1640c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau
Copy link
Contributor Author

a-maumau commented Sep 2, 2024

@SakodaShintaro I fixed the link error in the README.md.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that

  • logging_simulator
  • AWSIM (multi time initialpose estimation)
  • planning_simulator

and I checked

  • Directory Name

    • Add autoware_ as a prefix to the directory name.
  • packages.xml

    • Add autoware_ to the name element.
  • CMakeLists.txt

    • Change the project name to autoware_***.
    • Add autoware:: to PLUGIN.
  • Header Files (.hpp)

    • Add autoware:: to namespace.
  • Source Files (.cpp)

    • Add autoware:: inside RCLCPP_COMPONENTS_REGISTER_NODE.
  • Launch Files

    • Add autoware_ before find-pkg-share.
    • Change node pkg="<pkgname>" to autoware_<pkgname>.
  • Verification Points

    • Search find-pkg-share in autoware
    • Check README file (especially json schema)
    • Pay attention to complex cases like sensor_launch as seen in gnss_poser

LGTM

@SakodaShintaro
Copy link
Contributor

@KeisukeShima @taikitanaka3 @TakaHoribe @takayuki5168 @tkimura4
Can anyone review this pull request about "simulator.launch.xml"? The operation of logging_simulator, AWSIM and planning_simulator has been confirmed.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for simulator.launch.xml

@SakodaShintaro SakodaShintaro merged commit 03f675e into autowarefoundation:main Sep 3, 2024
31 checks passed
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…re (autowarefoundation#8701)

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* fix link

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants