-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pose_initializer)!: prefix package and namespace with autoware #8701
refactor(pose_initializer)!: prefix package and namespace with autoware #8701
Conversation
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@a-maumau |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8701 +/- ##
==========================================
- Coverage 24.13% 24.07% -0.06%
==========================================
Files 1400 1412 +12
Lines 102258 102514 +256
Branches 38763 38799 +36
==========================================
+ Hits 24679 24684 +5
- Misses 75086 75337 +251
Partials 2493 2493
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@SakodaShintaro I fixed the link error in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that
- logging_simulator
- AWSIM (multi time initialpose estimation)
- planning_simulator
and I checked
-
Directory Name
- Add
autoware_
as a prefix to the directory name.
- Add
-
packages.xml
- Add
autoware_
to thename
element.
- Add
-
CMakeLists.txt
- Change the
project
name toautoware_***
. - Add
autoware::
toPLUGIN
.
- Change the
-
Header Files (.hpp)
- Add
autoware::
tonamespace
.
- Add
-
Source Files (.cpp)
- Add
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.
- Add
-
Launch Files
- Add
autoware_
beforefind-pkg-share
. - Change
node pkg="<pkgname>"
toautoware_<pkgname>
.
- Add
-
Verification Points
- Search
find-pkg-share
in autoware - Check README file (especially json schema)
- Pay attention to complex cases like
sensor_launch
as seen ingnss_poser
- Search
LGTM
@KeisukeShima @taikitanaka3 @TakaHoribe @takayuki5168 @tkimura4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for simulator.launch.xml
…re (autowarefoundation#8701) * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * fix link Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Description
This PR will add an
autoware_
prefix topose_initializer
package.Also directory structure is changed to fit https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#include-and-src
Related links
Parent Issue:
How was this PR tested?
Checked that it works with the Autoware's sample ROS bag.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.