Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(raw_vehicle_cmd_converter): fix null check #8677

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 29, 2024

Description

Fixed a problem where nodes die or topics stop when certain parameters are set.
related to: #8504

Related links

Parent Issue:

  • Link

How was this PR tested?

ros2 launch tier4_vehicle_launch vehicle.launch.xml vehicle_model:=lexus sensor_model:=aip_xx1  launch_vehicle_interface:=true

ros2 bag  play 1feddd62-ce45-41ee-bed6-3dcdb06ccc8e_2024-08-29-14-23-07_p0900_1.db3 --topics /control/command/control_cmd /localization/kinematic_state /vehicle/status/steering_status /vehicle/status/actuation_status --clock 100

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Aug 29, 2024
Copy link

github-actions bot commented Aug 29, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 24.14%. Comparing base (fb6fd8d) to head (fe019ba).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...le/autoware_raw_vehicle_cmd_converter/src/node.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8677      +/-   ##
==========================================
- Coverage   24.14%   24.14%   -0.01%     
==========================================
  Files        1400     1401       +1     
  Lines      102278   102307      +29     
  Branches    38765    38768       +3     
==========================================
  Hits        24699    24699              
- Misses      75038    75067      +29     
  Partials     2541     2541              
Flag Coverage Δ *Carryforward flag
differential 4.58% <0.00%> (?)
total 24.14% <ø> (+<0.01%) ⬆️ Carriedforward from fb6fd8d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the fix/raw_vehicle_cmd_converter branch from ee13d91 to fe019ba Compare August 29, 2024 14:35
@kosuke55 kosuke55 enabled auto-merge (squash) August 29, 2024 14:35
@kosuke55 kosuke55 merged commit 7e4cd9d into autowarefoundation:main Aug 29, 2024
24 of 25 checks passed
@kosuke55 kosuke55 deleted the fix/raw_vehicle_cmd_converter branch August 29, 2024 14:42
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants