Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_static_centerline_generator): fix unusedFunction #8647

Merged

Conversation

kobayu858
Copy link
Contributor

@kobayu858 kobayu858 commented Aug 27, 2024

Description

This is a fix based on cppcheck unusedFunction warnings.

planning/autoware_static_centerline_generator/src/static_centerline_generator_node.cpp:600:0: style: The function 'update_road_boundary' is never used. [unusedFunction]
RoadBounds StaticCenterlineGeneratorNode::update_road_boundary(
^

planning/autoware_static_centerline_generator/src/utils.cpp:260:0: style: The function 'calcBoundsFromLanelets' is never used. [unusedFunction]
calcBoundsFromLanelets(const lanelet::ConstLanelets lanelets)
^

planning/autoware_static_centerline_generator/src/static_centerline_generator_node.cpp:180:0: style: The function 'arePointsClose' is never used. [unusedFunction]
bool arePointsClose(
^
planning/autoware_static_centerline_generator/src/static_centerline_generator_node.cpp:186:0: style: The function 'areSameDirection' is never used. [unusedFunction]
bool areSameDirection(
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 requested a review from veqcc August 27, 2024 11:11
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 27, 2024
@kobayu858
Copy link
Contributor Author

About update_road_boundary
// const auto road_bounds = update_road_boundary(selected_centerline);
The location used above was commented out, so I removed it as it is not currently used.

Copy link

github-actions bot commented Aug 27, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 28, 2024
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.06%. Comparing base (b9b0fa9) to head (212a717).
Report is 41 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8647   +/-   ##
=======================================
  Coverage   24.06%   24.06%           
=======================================
  Files        1398     1405    +7     
  Lines      102639   102639           
  Branches    39023    38984   -39     
=======================================
  Hits        24704    24704           
  Misses      75403    75403           
  Partials     2532     2532           
Flag Coverage Δ *Carryforward flag
differential 9.24% <ø> (?)
total 24.08% <ø> (+0.01%) ⬆️ Carriedforward from b9b0fa9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858 kobayu858 requested a review from takayuki5168 August 28, 2024 04:15
@kobayu858
Copy link
Contributor Author

@takayuki5168
I found a new warning and have removed arePointsClose and areSameDirection.

I would appreciate it if you could check again.

@kobayu858 kobayu858 merged commit 9323780 into autowarefoundation:main Aug 28, 2024
30 of 31 checks passed
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…refoundation#8647)

* fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:compile error

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…refoundation#8647)

* fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:compile error

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_unusedFunction_pla-8 branch October 1, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants