Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image_projection_based_fusion): remove unused variable #8634

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Aug 27, 2024

Description

Solve cpp warn check. Related to #8354.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Aug 27, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 27, 2024
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.07%. Comparing base (e0ecdda) to head (606ad68).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8634      +/-   ##
==========================================
- Coverage   24.09%   24.07%   -0.03%     
==========================================
  Files        1399     1400       +1     
  Lines      102440   102455      +15     
  Branches    38912    38912              
==========================================
- Hits        24682    24661      -21     
+ Misses      75213    75207       -6     
- Partials     2545     2587      +42     
Flag Coverage Δ *Carryforward flag
differential 2.99% <ø> (?)
total 24.07% <ø> (-0.03%) ⬇️ Carriedforward from e0ecdda

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YoshiRi YoshiRi merged commit 88b1658 into autowarefoundation:main Aug 27, 2024
40 of 41 checks passed
@YoshiRi YoshiRi deleted the fix/unused_variable_tlr branch August 27, 2024 00:13
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…oundation#8634)

fix: remove unused variable

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…oundation#8634)

fix: remove unused variable

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…oundation#8634)

fix: remove unused variable

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants