refactor(start_planner): remove redundant calculation in shift pull out #8623
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Aug 26, 2024 in 39s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.01 (7.81 -> 7.82)
- Improving Code Health: 2 findings(s) ✅
Details
✅ Improving Code Health:
- Complex Method shift_pull_out.cpp: ShiftPullOut::calcPullOutPaths
- Bumpy Road Ahead shift_pull_out.cpp: ShiftPullOut::calcPullOutPaths
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
ShiftPullOut::calcPullOutPaths decreases in cyclomatic complexity from 25 to 23, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Bumpy Road Ahead
ShiftPullOut::calcPullOutPaths decreases from 3 to 2 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading