Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(freespace_planner): fix free space planner spamming message #8614

Conversation

mkquda
Copy link
Contributor

@mkquda mkquda commented Aug 26, 2024

Description

Freespace planner node spams the message Waiting for occupancy grid when parking scenario is not active.

Changes

Update input data and check data availability only when parking scenario is active.

Related links

None.

How was this PR tested?

PSIM

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 26, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mkquda mkquda added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Aug 26, 2024
@mkquda mkquda added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 24.09%. Comparing base (c9bb1e1) to head (e2c2a48).
Report is 6 commits behind head on main.

Files Patch % Lines
...oware_freespace_planner/freespace_planner_node.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8614      +/-   ##
==========================================
- Coverage   24.10%   24.09%   -0.01%     
==========================================
  Files        1399     1400       +1     
  Lines      102455   102478      +23     
  Branches    38912    38915       +3     
==========================================
- Hits        24694    24693       -1     
- Misses      75223    75247      +24     
  Partials     2538     2538              
Flag Coverage Δ *Carryforward flag
differential 0.01% <0.00%> (?)
total 24.10% <ø> (+<0.01%) ⬆️ Carriedforward from c9bb1e1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkquda mkquda merged commit 1db4a65 into autowarefoundation:main Aug 26, 2024
51 of 54 checks passed
@mkquda mkquda deleted the RT1-7631-fix-free-space-planner-spamming-message branch August 26, 2024 06:26
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…warefoundation#8614)

check data availability only when scenario is active

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…warefoundation#8614)

check data availability only when scenario is active

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…warefoundation#8614)

check data availability only when scenario is active

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants