-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(autoware_autonomous_emergency_braking): improve AEB module's README #8612
docs(autoware_autonomous_emergency_braking): improve AEB module's README #8612
Conversation
Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8612 +/- ##
==========================================
- Coverage 24.10% 24.09% -0.01%
==========================================
Files 1399 1401 +2
Lines 102455 102484 +29
Branches 38928 38915 -13
==========================================
- Hits 24699 24696 -3
+ Misses 75267 75250 -17
- Partials 2489 2538 +49
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@kyoichi-sugahara thank you so much for the PR, could you please add this updated image to trplace the rss distance image that shows an rss distance that is shorter than object distance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
…DME (autowarefoundation#8612) * docs: improve AEB module's README Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> * update rss distance length Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
…DME (autowarefoundation#8612) * docs: improve AEB module's README Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> * update rss distance length Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
…DME (autowarefoundation#8612) * docs: improve AEB module's README Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> * update rss distance length Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
…DME (autowarefoundation#8612) * docs: improve AEB module's README Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> * update rss distance length Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
…DME (autowarefoundation#8612) * docs: improve AEB module's README Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> * update rss distance length Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
…DME (autowarefoundation#8612) * docs: improve AEB module's README Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> * update rss distance length Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
…DME (autowarefoundation#8612) * docs: improve AEB module's README Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> * update rss distance length Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Description
How was this PR tested?
None.
Notes for reviewers
None.
Effects on system behavior
None.