Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(autoware_autonomous_emergency_braking): improve AEB module's README #8612

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

  • Removed unreasonable assumption.
  • Added limitaion.

How was this PR tested?

None.

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Aug 26, 2024
Copy link

github-actions bot commented Aug 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.09%. Comparing base (b35ad4b) to head (379a9d5).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8612      +/-   ##
==========================================
- Coverage   24.10%   24.09%   -0.01%     
==========================================
  Files        1399     1401       +2     
  Lines      102455   102484      +29     
  Branches    38928    38915      -13     
==========================================
- Hits        24699    24696       -3     
+ Misses      75267    75250      -17     
- Partials     2489     2538      +49     
Flag Coverage Δ *Carryforward flag
differential 5.79% <ø> (?)
total 24.10% <ø> (-0.01%) ⬇️ Carriedforward from 1053bfc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran
Copy link
Contributor

@kyoichi-sugahara thank you so much for the PR, could you please add this updated image to trplace the rss distance image that shows an rss distance that is shorter than object distance?
AEB-rss-distance-emergency drawio (1)

Copy link
Contributor

@danielsanchezaran danielsanchezaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kyoichi-sugahara and others added 2 commits August 26, 2024 17:00
Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara merged commit fe953a4 into autowarefoundation:main Aug 26, 2024
31 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the docs/update_AEB_documentation branch August 26, 2024 08:21
kyoichi-sugahara added a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…DME (autowarefoundation#8612)

* docs: improve AEB module's README

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

* update rss distance length

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
---------

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…DME (autowarefoundation#8612)

* docs: improve AEB module's README

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

* update rss distance length

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
---------

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Sep 11, 2024
…DME (autowarefoundation#8612)

* docs: improve AEB module's README

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

* update rss distance length

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
---------

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Sep 16, 2024
…DME (autowarefoundation#8612)

* docs: improve AEB module's README

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

* update rss distance length

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
---------

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…DME (autowarefoundation#8612)

* docs: improve AEB module's README

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

* update rss distance length

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
---------

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Oct 28, 2024
…DME (autowarefoundation#8612)

* docs: improve AEB module's README

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

* update rss distance length

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
---------

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Nov 14, 2024
…DME (autowarefoundation#8612)

* docs: improve AEB module's README

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

* update rss distance length

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
---------

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants