fix(goal_planner): remove time keeper in non main thread #8610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
soblin
approved these changes
Aug 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8610 +/- ##
==========================================
- Coverage 24.06% 24.05% -0.02%
==========================================
Files 1398 1402 +4
Lines 102639 102695 +56
Branches 39023 39025 +2
==========================================
Hits 24704 24704
- Misses 75403 75459 +56
Partials 2532 2532
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 26, 2024
…ndation#8610) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
This was referenced Aug 26, 2024
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 26, 2024
fix(goal_planner): remove time keeper in non main thread (autowarefoundation#8610)
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 27, 2024
…ndation#8610) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Sep 2, 2024
…ndation#8610) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Sep 18, 2024
…ndation#8610) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
TetsuKawa
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 23, 2025
…ndation#8610) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
these functions are called in
void GoalPlannerModule::onTimer()which is in not in main thread. so remove time_keeper from these functions.Related links
Parent Issue:
How was this PR tested?
not tested
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.