fix(lane_change): update rtc status for some failure condition #8604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
maxime-clem
approved these changes
Aug 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8604 +/- ##
==========================================
- Coverage 24.06% 24.06% -0.01%
==========================================
Files 1398 1399 +1
Lines 102639 102669 +30
Branches 39023 39024 +1
==========================================
+ Hits 24704 24707 +3
- Misses 75403 75430 +27
Partials 2532 2532
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 27, 2024
…arefoundation#8604) update rtc status for some failure condition Signed-off-by: Go Sakayori <gsakayori@gmail.com>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Sep 2, 2024
…arefoundation#8604) update rtc status for some failure condition Signed-off-by: Go Sakayori <gsakayori@gmail.com>
go-sakayori
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 9, 2024
…arefoundation#8604) update rtc status for some failure condition Signed-off-by: Go Sakayori <gsakayori@gmail.com>
1 task
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Sep 18, 2024
…arefoundation#8604) update rtc status for some failure condition Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this previous PR #7436, some conditions were added so that the state will transit from
RUNNINGtoFAILURE. The module itself would transit to the appropriate state however, the RTC cooperateStatus would not be updated. In this PR I have resolved this problem by calling theupdateRTCStatusfunction by providing theFAILUREstatus.Related links
#7436
How was this PR tested?
https://evaluation.tier4.jp/evaluation/reports/1f0f0af5-d1b1-579a-890b-be2aa856e208?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.