fix(autoware_pointcloud_preprocessor): resolve issue with FLT_MAX not declared on Jazzy #8586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
e5f8d65 to
c9d52ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8586 +/- ##
==========================================
- Coverage 23.93% 23.92% -0.01%
==========================================
Files 1384 1386 +2
Lines 102106 102133 +27
Branches 38912 38911 -1
==========================================
- Hits 24435 24432 -3
- Misses 75195 75226 +31
+ Partials 2476 2475 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@reinzor Please run the pre-commit on your local, thanks! |
Fixes compilation error on Jazzy: error: ‘FLT_MAX’ was not declared in this scope Signed-off-by: Rein Appeldoorn <rein.appeldoorn@nobleo.nl>
c9d52ef to
105bd3a
Compare
done |
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Sep 2, 2024
… declared on Jazzy (autowarefoundation#8586) fix(pointcloud-preprocessor): FLT_MAX not declared Fixes compilation error on Jazzy: error: ‘FLT_MAX’ was not declared in this scope Signed-off-by: Rein Appeldoorn <rein.appeldoorn@nobleo.nl>
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Sep 18, 2024
… declared on Jazzy (autowarefoundation#8586) fix(pointcloud-preprocessor): FLT_MAX not declared Fixes compilation error on Jazzy: error: ‘FLT_MAX’ was not declared in this scope Signed-off-by: Rein Appeldoorn <rein.appeldoorn@nobleo.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compilation error on Jazzy:
error: ‘FLT_MAX’ was not declared in this scope