Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ekf_localizer): fix tf2 listener #8584

Conversation

YamatoAndo
Copy link
Contributor

Description

In the ekf_localizer node, there is a strange way of writing for tf_listener , so I fixed it.

Related links

Parent Issue:

  • Link

How was this PR tested?

Lsim works

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, I think it's fine, but I understand that the behavior has changed.
get_transform_from_tf used to wait for tf for up to 5 seconds, it doesn't wait after the change.
I just want to remember that this PR may be a problem in very specific cases.

@YamatoAndo
Copy link
Contributor Author

@SakodaShintaro If you're concerned about it, should we implement it using canTransform?

@SakodaShintaro
Copy link
Contributor

I see https://docs.ros.org/en/indigo/api/tf2_ros/html/c++/classtf2__ros_1_1Buffer.html#a2971d78ba006fd6c3dd67c53870317fd

timeout	How long to block before failing

This argument seems to be able to reproduce the previous behavior almost completely.

I don't think there's any need to fix to use this.

@YamatoAndo YamatoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.00%. Comparing base (b247c43) to head (723dbc1).
Report is 37 commits behind head on main.

Files Patch % Lines
localization/ekf_localizer/src/ekf_localizer.cpp 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8584   +/-   ##
=======================================
  Coverage   23.99%   24.00%           
=======================================
  Files        1384     1384           
  Lines      102173   102178    +5     
  Branches    38956    38958    +2     
=======================================
+ Hits        24520    24525    +5     
  Misses      75180    75180           
  Partials     2473     2473           
Flag Coverage Δ *Carryforward flag
differential 31.43% <66.66%> (?)
total 23.99% <ø> (-0.01%) ⬇️ Carriedforward from b247c43

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YamatoAndo YamatoAndo merged commit 3f01566 into autowarefoundation:main Aug 26, 2024
39 of 41 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
* fix tf2 listener

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
* fix tf2 listener

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
* fix tf2 listener

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants