-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ekf_localizer): fix tf2 listener #8584
refactor(ekf_localizer): fix tf2 listener #8584
Conversation
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, I think it's fine, but I understand that the behavior has changed.
get_transform_from_tf
used to wait for tf for up to 5 seconds, it doesn't wait after the change.
I just want to remember that this PR may be a problem in very specific cases.
@SakodaShintaro If you're concerned about it, should we implement it using canTransform? |
This argument seems to be able to reproduce the previous behavior almost completely. I don't think there's any need to fix to use this. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8584 +/- ##
=======================================
Coverage 23.99% 24.00%
=======================================
Files 1384 1384
Lines 102173 102178 +5
Branches 38956 38958 +2
=======================================
+ Hits 24520 24525 +5
Misses 75180 75180
Partials 2473 2473
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* fix tf2 listener Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix tf2 listener Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix tf2 listener Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
In the ekf_localizer node, there is a strange way of writing for tf_listener , so I fixed it.
Related links
Parent Issue:
How was this PR tested?
Lsim works
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.