Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_tracking_object_merger): fix unusedFunction #8578

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck unusedFunction warnings.

perception/autoware_tracking_object_merger/src/utils/utils.cpp:301:0: style: The function 'objectsYawIsReverted' is never used. [unusedFunction]
bool objectsYawIsReverted(const TrackedObject & main_obj, const TrackedObject & sub_obj)
^

perception/autoware_tracking_object_merger/src/utils/utils.cpp:413:0: style: The function 'probabilityMerger' is never used. [unusedFunction]
float probabilityMerger(const float main_prob, const float sub_prob, const MergePolicy policy)
^

perception/autoware_tracking_object_merger/src/utils/utils.cpp:428:0: style: The function 'shapeMerger' is never used. [unusedFunction]
autoware_perception_msgs::msg::Shape shapeMerger(
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 requested a review from veqcc August 22, 2024 08:19
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Aug 22, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.01%. Comparing base (60cc9c7) to head (162a41c).
Report is 54 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8578   +/-   ##
=======================================
  Coverage   24.01%   24.01%           
=======================================
  Files        1384     1384           
  Lines      102173   102161   -12     
  Branches    38947    38939    -8     
=======================================
  Hits        24536    24536           
+ Misses      75138    75126   -12     
  Partials     2499     2499           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 24.01% <ø> (+<0.01%) ⬆️ Carriedforward from 60cc9c7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin
Copy link
Contributor

For my point of view, those functions provide additional functionalities for Autoware users. Even it is not used in current Autoware, someone can use those.

@YoshiRi @yukkysaito
Do you think those unused functions should be removed?

@YoshiRi
Copy link
Contributor

YoshiRi commented Aug 26, 2024

@technolojin
As you say I intended to use those function in the future development.
But this is trivial, so I think we can remove this.
Ref: https://star4.slack.com/archives/C4P0NSMB5/p1724040335846959

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Go ahead.

@kobayu858 kobayu858 merged commit 98d86b2 into autowarefoundation:main Aug 27, 2024
40 of 41 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…ndation#8578)

fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…ndation#8578)

fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…ndation#8578)

fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_unusedFunction_per-22 branch October 1, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants