-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autoware_probabilistic_occupancy_grid_map): fix unusedFunction #8574
fix(autoware_probabilistic_occupancy_grid_map): fix unusedFunction #8574
Conversation
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8574 +/- ##
=======================================
Coverage 24.01% 24.01%
=======================================
Files 1384 1384
Lines 102173 102162 -11
Branches 38947 38943 -4
=======================================
+ Hits 24536 24537 +1
+ Misses 75138 75127 -11
+ Partials 2499 2498 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- I confirmed that
getApproximateOccupancyState
andupdateGridMap
are not called in autoware. - I did NOT checked this PR by running autoware.
- Now I am checking the background of these functions here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense. LGTM
…utowarefoundation#8574) fix:unusedFunction Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
…utowarefoundation#8574) fix:unusedFunction Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
…utowarefoundation#8574) fix:unusedFunction Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
…utowarefoundation#8574) fix:unusedFunction Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Description
This is a fix based on cppcheck unusedFunction warnings.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.