Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_probabilistic_occupancy_grid_map): fix unusedFunction #8574

Merged

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck unusedFunction warnings.

perception/autoware_probabilistic_occupancy_grid_map/lib/utils/utils.cpp:199:0: style: The function 'getApproximateOccupancyState' is never used. [unusedFunction]
unsigned char getApproximateOccupancyState(const unsigned char & value)
^

perception/autoware_probabilistic_occupancy_grid_map/src/fusion/synchronized_grid_map_fusion_node.cpp:372:0: style: The function 'OccupancyGridMsgToCostmap2D' is never used. [unusedFunction]
nav2_costmap_2d::Costmap2D GridMapFusionNode::OccupancyGridMsgToCostmap2D(
^

perception/autoware_probabilistic_occupancy_grid_map/src/fusion/synchronized_grid_map_fusion_node.cpp:377:0: style: The function 'updateGridMap' is never used. [unusedFunction]
void GridMapFusionNode::updateGridMap(
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Aug 22, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 22, 2024
@kobayu858 kobayu858 requested a review from veqcc August 22, 2024 07:40
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.01%. Comparing base (60cc9c7) to head (22e9389).
Report is 60 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8574   +/-   ##
=======================================
  Coverage   24.01%   24.01%           
=======================================
  Files        1384     1384           
  Lines      102173   102162   -11     
  Branches    38947    38943    -4     
=======================================
+ Hits        24536    24537    +1     
+ Misses      75138    75127   -11     
+ Partials     2499     2498    -1     
Flag Coverage Δ *Carryforward flag
differential 12.83% <ø> (?)
total 24.01% <ø> (+<0.01%) ⬆️ Carriedforward from 60cc9c7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Shin-kyoto Shin-kyoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • I confirmed that getApproximateOccupancyState and updateGridMap are not called in autoware.
  • I did NOT checked this PR by running autoware.
  • Now I am checking the background of these functions here

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. LGTM

@YoshiRi YoshiRi merged commit 0a6f744 into autowarefoundation:main Aug 27, 2024
40 of 41 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…utowarefoundation#8574)

fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…utowarefoundation#8574)

fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Sep 2, 2024
…utowarefoundation#8574)

fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…utowarefoundation#8574)

fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_unusedFunction_per-16 branch October 1, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants