Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(autoware_default_adapi)!: prefix autoware to package name #8533

Merged
merged 3 commits into from
Aug 27, 2024
Merged

chore(autoware_default_adapi)!: prefix autoware to package name #8533

merged 3 commits into from
Aug 27, 2024

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Aug 20, 2024 •
edited
Loading

Description

Prefix "autoware" to package name.

Related links

Parent Issue:

How was this PR tested?

Run planning simulation and drive auto mode.
[TIER IV INTERNAL LINK] simulation test

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Aug 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@isamu-takagi isamu-takagi changed the title chore(autoware_default_adapi): prefix autoware to package name chore(autoware_default_adapi)!: prefix autoware to package name Aug 20, 2024
@isamu-takagi isamu-takagi self-assigned this Aug 21, 2024
@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 21, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.87%. Comparing base (b9b0fa9) to head (185d6b6).
Report is 22 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8533      +/-   ##
==========================================
- Coverage   24.06%   23.87%   -0.20%     
==========================================
  Files        1398     1420      +22     
  Lines      102639   102916     +277     
  Branches    39023    39168     +145     
==========================================
- Hits        24704    24570     -134     
- Misses      75403    75860     +457     
+ Partials     2532     2486      -46
Flag Coverage Δ *Carryforward flag
differential 14.83% <100.00%> (?)
total 23.92% <ø> (-0.15%) ⬇️ Carriedforward from 63139e9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi @mitsudome-r
chore(autoware_default_adapi): prefix autoware
edde1a5 
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi @mitsudome-r
fix package name
63139e9 
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@mitsudome-r mitsudome-r force-pushed the chore/default-adapi-prefix-autoware branch from f6bb20a to 63139e9 Compare August 22, 2024 06:36
@YamatoAndo YamatoAndo added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Aug 22, 2024
@github-actions GitHub Actions
Copy link

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-8533/
Modified URLs:

YamatoAndo
YamatoAndo approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@YamatoAndo YamatoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (localization/pose_initializer/README.md)

@isamu-takagi
Copy link
Contributor Author

@go-sakayori @kosuke55 @kyoichi-sugahara @satoshi-ota @shmpwk @takayuki5168 @TomohitoAndo @tkimura4
Can someone please review autoware_behavior_path_planner/README.md? Only link update.

mitsudome-r
mitsudome-r approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isamu-takagi isamu-takagi merged commit 93802fd into autowarefoundation:main Aug 27, 2024
32 of 33 checks passed
@isamu-takagi isamu-takagi deleted the chore/default-adapi-prefix-autoware branch August 27, 2024 02:17
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
@isamu-takagi @kyoichi-sugahara
chore(autoware_default_adapi)!: prefix autoware to package name (auto…
688b147 
…warefoundation#8533)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
@isamu-takagi @a-maumau
chore(autoware_default_adapi)!: prefix autoware to package name (auto…
836eb0c 
…warefoundation#8533)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
@isamu-takagi @ktro2828
chore(autoware_default_adapi)!: prefix autoware to package name (auto…
41ddd1c 
…warefoundation#8533)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YamatoAndo YamatoAndo YamatoAndo approved these changes

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@go-sakayori go-sakayori Awaiting requested review from go-sakayori go-sakayori is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi

@Motsu-san Motsu-san Awaiting requested review from Motsu-san

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto

@SakodaShintaro SakodaShintaro Awaiting requested review from SakodaShintaro

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4

Assignees

@isamu-takagi isamu-takagi

Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isamu-takagi @YamatoAndo @takayuki5168 @mitsudome-r