Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(object_recognition_utils): fix unusedFunction #8523

Merged

Conversation

Nagi70
Copy link
Contributor

@Nagi70 Nagi70 commented Aug 19, 2024

Description

This is a fix based on cppcheck unusedFunction warnings

common/object_recognition_utils/src/conversion.cpp:72:0: style: The function 'toTrackedObjects' is never used. [unusedFunction]
TrackedObjects toTrackedObjects(const DetectedObjects & detected_objects)
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Nagi70 <n.yoshimura.060@ms.saitama-u.ac.jp>
@Nagi70 Nagi70 requested a review from veqcc August 19, 2024 03:46
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Aug 19, 2024
Copy link

github-actions bot commented Aug 19, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Nagi70 Nagi70 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.86%. Comparing base (9a461b4) to head (a7c9777).
Report is 130 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8523      +/-   ##
==========================================
- Coverage   23.90%   23.86%   -0.04%     
==========================================
  Files        1381     1389       +8     
  Lines      101923   101940      +17     
  Branches    38808    38802       -6     
==========================================
- Hits        24363    24330      -33     
- Misses      75116    75137      +21     
- Partials     2444     2473      +29     
Flag Coverage Δ *Carryforward flag
differential 18.41% <ø> (?)
total 23.89% <ø> (-0.01%) ⬇️ Carriedforward from 69d16f4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858
Copy link
Contributor

@miursh @takayuki5168 @YoshiRi

Please confirm the PR. Thank you very much.

@kobayu858 kobayu858 merged commit 6d0262b into autowarefoundation:main Aug 28, 2024
29 of 30 checks passed
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…#8523)

fix: unusedFunction

Signed-off-by: Nagi70 <n.yoshimura.060@ms.saitama-u.ac.jp>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…#8523)

fix: unusedFunction

Signed-off-by: Nagi70 <n.yoshimura.060@ms.saitama-u.ac.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_unusedFunction_com-10 branch October 1, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants