Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_velocity_limiter): more stable virtual wall #8499

Merged

Conversation

maxime-clem
Copy link
Contributor

Description

Fix the obstacle_velocity_limiter adding virtual walls at each slowdown point. Now a wall is added only the first slowdown of an interval.
Also moved the check to prevent increasing the trajectory velocity to the node side.

Related links

Parent Issue:

  • Link

How was this PR tested?

Psim

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 15, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 15, 2024
Copy link

github-actions bot commented Aug 15, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 3.44828% with 28 lines in your changes missing coverage. Please review.

Project coverage is 24.09%. Comparing base (bda8706) to head (6bf1caa).
Report is 4 commits behind head on main.

Files Patch % Lines
...ty_limiter_module/src/trajectory_preprocessing.cpp 0.00% 11 Missing ⚠️
...y_limiter_module/src/obstacle_velocity_limiter.cpp 0.00% 10 Missing ⚠️
...autoware_motion_velocity_planner_node/src/node.cpp 0.00% 4 Missing ⚠️
...er_module/src/obstacle_velocity_limiter_module.cpp 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8499      +/-   ##
==========================================
- Coverage   24.10%   24.09%   -0.01%     
==========================================
  Files        1399     1403       +4     
  Lines      102337   102375      +38     
  Branches    38870    38874       +4     
==========================================
+ Hits        24668    24669       +1     
- Misses      75141    75177      +36     
- Partials     2528     2529       +1     
Flag Coverage Δ *Carryforward flag
differential 18.54% <3.44%> (?)
total 24.10% <ø> (+<0.01%) ⬆️ Carriedforward from bda8706

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem force-pushed the fix/obstacle_velocity_limiter branch from c1fc313 to 36b53cd Compare August 21, 2024 07:12
@maxime-clem maxime-clem changed the title fix(obstacle_velocity_limiter): only show the 1st virtual wall fix(obstacle_velocity_limiter): more stable virtual wall Aug 21, 2024
@maxime-clem maxime-clem force-pushed the fix/obstacle_velocity_limiter branch from 36b53cd to 9f5d093 Compare August 21, 2024 07:13
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the fix/obstacle_velocity_limiter branch from 9f5d093 to 6bf1caa Compare August 28, 2024 07:54
@maxime-clem maxime-clem merged commit a91af79 into autowarefoundation:main Aug 28, 2024
30 of 31 checks passed
@maxime-clem maxime-clem deleted the fix/obstacle_velocity_limiter branch August 28, 2024 08:17
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants