Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add autoware prefix #8385

Conversation

ktro2828
Copy link
Contributor

@ktro2828 ktro2828 commented Aug 7, 2024

Description

Related to #8085.
This PR added autoware prefix to the executable in the launcher.

Related links

Parent Issue:

  • Link

How was this PR tested?

I confirmed the launcher works.

  • Before
$ ros2 launch autoware_path_distance_calculator path_distance_calculator.launch.xml 
[INFO] [launch]: All log files can be found below /home/ktro2828/.ros/log/2024-08-07-09-15-56-427441-ktro2828-desktop-1632096
[INFO] [launch]: Default logging verbosity is set to INFO
[ERROR] [launch]: Caught exception in launch (see debug for traceback): executable 'path_distance_calculator_node' not found on the libexec directory '/home/ktro2828/workspace/pilot-auto/install/autoware_path_distance_calculator/lib/autoware_path_distance_calculator' 
  • After
$ ros2 launch autoware_path_distance_calculator path_distance_calculator.launch.xml 
[INFO] [launch]: All log files can be found below /home/ktro2828/.ros/log/2024-08-07-09-23-32-333349-ktro2828-desktop-1652434
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [autoware_path_distance_calculator_node-1]: process started with pid [1652435]

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 requested a review from isamu-takagi as a code owner August 7, 2024 00:24
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.76%. Comparing base (b68cce2) to head (1d3696e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8385      +/-   ##
==========================================
- Coverage   23.77%   23.76%   -0.01%     
==========================================
  Files        1379     1380       +1     
  Lines      101359   101384      +25     
  Branches    38519    38523       +4     
==========================================
  Hits        24098    24098              
- Misses      74768    74793      +25     
  Partials     2493     2493              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 23.77% <ø> (ø) Carriedforward from b68cce2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ktro2828 ktro2828 enabled auto-merge (squash) August 7, 2024 01:07
@ktro2828 ktro2828 merged commit 389683f into autowarefoundation:main Aug 7, 2024
39 checks passed
@ktro2828 ktro2828 deleted the fix/autoware_path_generator/prefix branch August 7, 2024 01:27
@esteve
Copy link
Contributor

esteve commented Aug 7, 2024

@ktro2828 thank you very much for the fix

esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: xtk8532704 <1041084556@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants