-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lane_change): skip generating path if longitudinal distance difference is less than threshold #8363
fix(lane_change): skip generating path if longitudinal distance difference is less than threshold #8363
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
602aac7
to
5213b10
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
5213b10
to
158b6d2
Compare
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and a quick test in Psim did not reveal any issue.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8363 +/- ##
==========================================
- Coverage 23.72% 23.72% -0.01%
==========================================
Files 1379 1380 +1
Lines 101392 101409 +17
Branches 38522 38534 +12
==========================================
+ Hits 24058 24061 +3
- Misses 74913 74927 +14
Partials 2421 2421
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9876c76
into
autowarefoundation:main
…rence is less than threshold (autowarefoundation#8363) * fix when prepare length is insufficient Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add reason for comparing prev_prep_diff with eps for lc_length_diff Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…rence is less than threshold (autowarefoundation#8363) * fix when prepare length is insufficient Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add reason for comparing prev_prep_diff with eps for lc_length_diff Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…rence is less than threshold (autowarefoundation#8363) * fix when prepare length is insufficient Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add reason for comparing prev_prep_diff with eps for lc_length_diff Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…rence is less than threshold (autowarefoundation#8363) * fix when prepare length is insufficient Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add reason for comparing prev_prep_diff with eps for lc_length_diff Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: xtk8532704 <1041084556@qq.com>
…rence is less than threshold (autowarefoundation#8363) * fix when prepare length is insufficient Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add reason for comparing prev_prep_diff with eps for lc_length_diff Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Mukunda Bharatheesha <mukunda.bharatheesha@nobleo.nl>
…rence is less than threshold (autowarefoundation#8363) * fix when prepare length is insufficient Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add reason for comparing prev_prep_diff with eps for lc_length_diff Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Description
Current behavior:
The number of lane change samples increases as ego vehicle approaches terminal start, due to the greater number of longitudinal acceleration samples.
The increase in lane change samples also leads to higher computational costs, as each sample generates a candidate path and undergoes various validations.
Proposed behavior:
Each lane change sample is computed based on the corresponding longitudinal acceleration sample.
As the ego vehicle approaches the terminal start, the distance differences between each lane change sample become smaller.
In this case, if the distance difference is small and the previous path is unsafe, it's likely that the new path with a small distance difference will also be unsafe. Therefore, it is feasible to skip generating paths with small distance differences and focus on those with larger differences instead.
Following are the illustrations of the proposed behavior
Before PR
Has more number of candidate path (5 samples) and processing time is between 7~10ms.
beforePR.mp4
After PR
Has less number of candidate path (3 sample) and processing time is between 5~8ms.
afterPR.mp4
Related links
Required #8362
Required launcher: autowarefoundation/autoware_launch#1108
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.