-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): use different rss param to deal with parked vehicle #8316
feat(lane_change): use different rss param to deal with parked vehicle #8316
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good 👍
@@ -2069,9 +2069,14 @@ PathSafetyStatus NormalLaneChange::isLaneChangePathSafe( | |||
const auto obj_predicted_paths = utils::path_safety_checker::getPredictedPathFromObj( | |||
obj, lane_change_parameters_->use_all_predicted_path); | |||
auto is_safe = true; | |||
const auto selected_rss_param = | |||
(obj.initial_twist.twist.linear.x <= | |||
lane_change_parameters_->prepare_segment_ignore_object_velocity_thresh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(minor) prepare_segment_ignore_object_velocity_thresh
this parameter should probably be renamed since the object is not ignored (can be done in a future PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I plan to rename it to something else in the later PR.
2ba4a22
to
b5e22ea
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
b5e22ea
to
3dfcc0e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8316 +/- ##
===========================================
- Coverage 15.09% 10.96% -4.14%
===========================================
Files 1967 267 -1700
Lines 135941 27475 -108466
Branches 42122 4864 -37258
===========================================
- Hits 20520 3012 -17508
+ Misses 92700 24087 -68613
+ Partials 22721 376 -22345
☔ View full report in Codecov by Sentry. |
f07fa8e
into
autowarefoundation:main
autowarefoundation#8316) * different rss value for parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Documentation and config file update Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
autowarefoundation#8316) * different rss value for parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Documentation and config file update Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
autowarefoundation#8316) * different rss value for parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Documentation and config file update Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
autowarefoundation#8316) * different rss value for parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Documentation and config file update Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
autowarefoundation#8316) * different rss value for parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Documentation and config file update Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
autowarefoundation#8316) * different rss value for parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Documentation and config file update Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
autowarefoundation#8316) * different rss value for parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Documentation and config file update Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
autowarefoundation#8316) * different rss value for parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Documentation and config file update Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
autowarefoundation#8316) * different rss value for parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Documentation and config file update Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Description
Available RSS parameters is too conservative for parked vehicle.
In this PR, RSS parameters for parked vehicle is separated to relax the criteria.
Related links
autowarefoundation/autoware_launch#1104
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
ROS Parameter Changes
Additions and removals
safety_check.parked.expected_front_deceleration
double
-1.0
safety_check.parked.expected_rear_deceleration
double
-2.0
safety_check.parked.rear_vehicle_reaction_time
double
1.0
safety_check.parked.rear_vehicle_safety_time_margin
double
0.8
safety_check.parked.lateral_distance_max_threshold
double
1.0
safety_check.parked.longitudinal_distance_min_threshold
double
3.0
safety_check.parked.longitudinal_velocity_delta_time
double
0.8
Effects on system behavior
None.