Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(twist2accel)!: prefix package and namespace with autoware #8299

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Aug 1, 2024

Description

This PR will add a autoware_ prefix to twist2accel.

Related links

autowarefoundation/autoware#4569

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

a-maumau added 2 commits July 29, 2024 18:53
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.29%. Comparing base (2601642) to head (562214e).

Files Patch % Lines
...alization/autoware_twist2accel/src/twist2accel.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8299      +/-   ##
==========================================
- Coverage   29.30%   29.29%   -0.02%     
==========================================
  Files        1609     1610       +1     
  Lines      119413   119460      +47     
  Branches    51478    51481       +3     
==========================================
  Hits        34990    34990              
- Misses      75120    75167      +47     
  Partials     9303     9303              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.30% <ø> (ø) Carriedforward from 2601642

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator and AWSIM work well.

Also, I checked

  • Directory Name

    • Add autoware_ as a prefix to the directory name.
  • packages.xml

    • Add autoware_ to the name element.
  • CMakeLists.txt

    • Change the project name to autoware_***.
    • Add autoware:: to PLUGIN.
  • Header Files (.hpp)

    • Add autoware:: to namespace.
  • Source Files (.cpp)

    • Add autoware:: inside RCLCPP_COMPONENTS_REGISTER_NODE.
  • Launch Files

    • Add autoware_ before find-pkg-share.
    • Change node pkg="<pkgname>" to autoware_<pkgname>.
  • Include

    • Add autoware folder as necessary and update include statements accordingly.
    • Check for impacts on other packages.
  • Verification Points

    • Search find-pkg-share in autoware
    • Check README file (especially json schema)
    • Pay attention to complex cases like sensor_launch as seen in gnss_poser

@SakodaShintaro SakodaShintaro merged commit ca32505 into autowarefoundation:main Aug 6, 2024
29 of 30 checks passed
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…utowarefoundation#8299)

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add autoware_ prefix

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants