-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(twist2accel)!: prefix package and namespace with autoware #8299
refactor(twist2accel)!: prefix package and namespace with autoware #8299
Conversation
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8299 +/- ##
==========================================
- Coverage 29.30% 29.29% -0.02%
==========================================
Files 1609 1610 +1
Lines 119413 119460 +47
Branches 51478 51481 +3
==========================================
Hits 34990 34990
- Misses 75120 75167 +47
Partials 9303 9303
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that logging_simulator and AWSIM work well.
Also, I checked
-
Directory Name
- Add
autoware_
as a prefix to the directory name.
- Add
-
packages.xml
- Add
autoware_
to thename
element.
- Add
-
CMakeLists.txt
- Change the
project
name toautoware_***
. - Add
autoware::
toPLUGIN
.
- Change the
-
Header Files (.hpp)
- Add
autoware::
tonamespace
.
- Add
-
Source Files (.cpp)
- Add
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.
- Add
-
Launch Files
- Add
autoware_
beforefind-pkg-share
. - Change
node pkg="<pkgname>"
toautoware_<pkgname>
.
- Add
-
Include
- Add
autoware
folder as necessary and update include statements accordingly. - Check for impacts on other packages.
- Add
-
Verification Points
- Search
find-pkg-share
in autoware - Check README file (especially json schema)
- Pay attention to complex cases like
sensor_launch
as seen ingnss_poser
- Search
ca32505
into
autowarefoundation:main
…utowarefoundation#8299) * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * add autoware_ prefix Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Description
This PR will add a
autoware_
prefix totwist2accel
.Related links
autowarefoundation/autoware#4569
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.