-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(autoware_imu_corrector): refactored the imu corrector into the autoware namespace #8222
chore(autoware_imu_corrector): refactored the imu corrector into the autoware namespace #8222
Conversation
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@knzo25 Hello. Thank you for the PR. I have a question. |
@knzo25 |
…ctor Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@YamatoAndo @TaikiYamada4 With regards to the launchers, also awsim was missing, which was addressed in There is also awsim_labs, but that should sync itself to the upstream |
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@YamatoAndo @TaikiYamada4 |
@knzo25 Sorry for the confusion. I was waiting, thinking that you would submit a fix PR for other repositories as well. Additionally, could you check if there are any other items that need to be fixed? |
@YamatoAndo I sent the respective PRs, and used GHUSER=tier4; curl "https://api.github.com/users/$GHUSER/repos?per_page=1000" | grep -o 'git@[^"]*' | xargs -L1 git clone
GHORG=autowarefoundation; curl "https://api.github.com/orgs/$GHORG/repos?per_page=1000" | grep -o 'git@[^"]*' | xargs -L1 git clone to check for occurrences in all autowarefoundation and tier4 repositories. Other than the PRs I opened, the following repositories had matched, but do not seem to be maintained: |
@YamatoAndo @TaikiYamada4 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8222 +/- ##
==========================================
- Coverage 24.08% 23.83% -0.25%
==========================================
Files 1399 1383 -16
Lines 102453 100598 -1855
Branches 38913 38097 -816
==========================================
- Hits 24673 23981 -692
+ Misses 75193 74143 -1050
+ Partials 2587 2474 -113
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that imu_corrector and gyro_bias_estimator works with this PR and relevant PRs via the sample rosbag replay tutorial.
LGTM and do not forget to merge the relavant PRs at once as possible.
…autoware namespace (autowarefoundation#8222) * chore: refactored the imu corrector into the autoware namespace Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: reverted to non-exported includes Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
…autoware namespace (autowarefoundation#8222) * chore: refactored the imu corrector into the autoware namespace Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: reverted to non-exported includes Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
…autoware namespace (autowarefoundation#8222) * chore: refactored the imu corrector into the autoware namespace Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: reverted to non-exported includes Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
Description
Part of the autoware namespace series of PRs
Needs to be merged with:
Related links
Parent Issue:
How was this PR tested?
Tested that the nodes were correctly launched
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.