Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_imu_corrector): refactored the imu corrector into the autoware namespace #8222

Merged
merged 7 commits into from
Aug 26, 2024

Conversation

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 self-assigned this Jul 26, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jul 26, 2024
Copy link

github-actions bot commented Jul 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@YamatoAndo
Copy link
Contributor

@knzo25 Hello. Thank you for the PR. I have a question.
Why did you move the .hpp files to the include/autoware directory?
If they are not intended for external export, they should be placed in the src directory.
https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#include-and-src

@TaikiYamada4
Copy link
Contributor

@knzo25
Thank you for the PR!
I found that sample_sensor_kit_launch also needs modification too, so could you modify sample_sensor_kit_launch too as same as aip_launcher?
https://github.com/autowarefoundation/sample_sensor_kit_launch/blob/main/sample_sensor_kit_launch/launch/imu.launch.xml

…ctor

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25
Copy link
Contributor Author

knzo25 commented Aug 1, 2024

@YamatoAndo @TaikiYamada4
Thanks for the catches 🙇 .

With regards to the launchers, also awsim was missing, which was addressed in
tier4/awsim_sensor_kit_launch#16
autowarefoundation/sample_sensor_kit_launch#99

There is also awsim_labs, but that should sync itself to the upstream

@knzo25
Copy link
Contributor Author

knzo25 commented Aug 6, 2024

@YamatoAndo @TaikiYamada4
anything blocking this PR?

@YamatoAndo
Copy link
Contributor

@knzo25
Copy link
Contributor Author

knzo25 commented Aug 13, 2024

@YamatoAndo
Apologies, I missed the documentation one, and completely forgot the existence of the tools repository.

I sent the respective PRs, and used

GHUSER=tier4; curl "https://api.github.com/users/$GHUSER/repos?per_page=1000" | grep -o 'git@[^"]*' | xargs -L1 git clone
GHORG=autowarefoundation; curl "https://api.github.com/orgs/$GHORG/repos?per_page=1000" | grep -o 'git@[^"]*' | xargs -L1 git clone

to check for occurrences in all autowarefoundation and tier4 repositories.

Other than the PRs I opened, the following repositories had matched, but do not seem to be maintained:
https://github.com/autowarefoundation/itri_bus_sensor_kit
https://github.com/autowarefoundation/awf_reference_sensor_kit_launch

@knzo25
Copy link
Contributor Author

knzo25 commented Aug 20, 2024

@YamatoAndo @TaikiYamada4
friendly ping

@TaikiYamada4 TaikiYamada4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.83%. Comparing base (a24e206) to head (d3f716a).
Report is 3 commits behind head on main.

Files Patch % Lines
.../autoware_imu_corrector/src/imu_corrector_core.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8222      +/-   ##
==========================================
- Coverage   24.08%   23.83%   -0.25%     
==========================================
  Files        1399     1383      -16     
  Lines      102453   100598    -1855     
  Branches    38913    38097     -816     
==========================================
- Hits        24673    23981     -692     
+ Misses      75193    74143    -1050     
+ Partials     2587     2474     -113     
Flag Coverage Δ *Carryforward flag
differential 4.02% <50.00%> (?)
total 23.85% <ø> (-0.23%) ⬇️ Carriedforward from a4b982f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TaikiYamada4 TaikiYamada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that imu_corrector and gyro_bias_estimator works with this PR and relevant PRs via the sample rosbag replay tutorial.
LGTM and do not forget to merge the relavant PRs at once as possible.

@knzo25 knzo25 merged commit e0ecdda into autowarefoundation:main Aug 26, 2024
31 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…autoware namespace (autowarefoundation#8222)

* chore: refactored the imu corrector into the autoware namespace

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* chore: reverted to non-exported includes

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…autoware namespace (autowarefoundation#8222)

* chore: refactored the imu corrector into the autoware namespace

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* chore: reverted to non-exported includes

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…autoware namespace (autowarefoundation#8222)

* chore: refactored the imu corrector into the autoware namespace

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* chore: reverted to non-exported includes

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants