Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: image transport decompressor/autoware prefix #8197

Merged
merged 8 commits into from
Jul 29, 2024
Merged

refactor: image transport decompressor/autoware prefix #8197

merged 8 commits into from
Jul 29, 2024

Conversation

manato
Copy link
Contributor

@manato manato commented Jul 25, 2024 •
edited
Loading

Description

This PR introduces autoware namespace into the image_transport_decompressor package

Related links

Parent Issue:

How was this PR tested?

I tested this PR as follows:

  1. ros2 launch autoware_image_transport_decompressor image_transport_decompressor.launch.xml
  2. ros2 launch autoware_tensorrt_yolox yolox.launch.xml

Notes for reviewers

This PR affects the following repository:

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

manato added 6 commits July 25, 2024 20:24
@manato
refactor: add autoware namespace prefix to image_transport_decompre…
2d90df9 
…ssor

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
@manato
refactor(image_transport_decompressor): add autoware prefix to the …
8e79dfb 
…package code

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
@manato
refactor: update package name in CODEOWNER
8f4197f 
Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
@manato
fix: merge main into the branch
467ac54 
Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
@manato
refactor: update packages which depend on image_transport_decompressor
89c4977 
Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
@manato
refactor(image_transport_decompressor): update README
882c748 
Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
@manato manato force-pushed the refactor/image_transport_decompressor/autoware-prefix branch from 5bf6e7c to 882c748 Compare July 25, 2024 11:24
@manato manato marked this pull request as ready for review July 25, 2024 11:25
yukkysaito
yukkysaito approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jul 25, 2024
Closed
Closed
technolojin
technolojin approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knzo25
Copy link
Contributor

knzo25 commented Jul 28, 2024

@dan-dnn
It seems we need your review here

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 29, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.24%. Comparing base (3d849e9) to head (1a38697).
Report is 915 commits behind head on main.

Files Patch % Lines
..._decompressor/src/image_transport_decompressor.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #8197       +/-   ##
===========================================
+ Coverage   15.09%   29.24%   +14.15%     
===========================================
  Files        1967     1602      -365     
  Lines      135941   117792    -18149     
  Branches    42122    50720     +8598     
===========================================
+ Hits        20520    34450    +13930     
+ Misses      92700    74114    -18586     
+ Partials    22721     9228    -13493
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.26% <ø> (+14.16%) ⬆️ Carriedforward from 95aef0d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dan-dnn
dan-dnn approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@dan-dnn dan-dnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late confirmation.
LGTM.

@technolojin technolojin merged commit 083ed2f into autowarefoundation:main Jul 29, 2024
29 of 30 checks passed
@manato manato deleted the refactor/image_transport_decompressor/autoware-prefix branch July 29, 2024 07:34
@MasatoSaeki MasatoSaeki mentioned this pull request Aug 5, 2024
Merged
5 tasks
@TZECHIN6 TZECHIN6 mentioned this pull request Aug 12, 2024
Closed
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
@manato @pre-commit-ci
@technolojin @esteve
refactor: image transport decompressor/autoware prefix (autowarefound…
6d2fb1d 
…ation#8197)

* refactor: add `autoware` namespace prefix to image_transport_decompressor

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

* refactor(image_transport_decompressor): add `autoware` prefix to the package code

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

* refactor: update package name in CODEOWNER

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

* fix: merge main into the branch

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

* refactor: update packages which depend on image_transport_decompressor

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

* refactor(image_transport_decompressor): update README

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Taekjin LEE <taekjin.lee@tier4.jp>
@esteve esteve mentioned this pull request Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@technolojin technolojin technolojin approved these changes

@dan-dnn dan-dnn dan-dnn approved these changes

@knzo25 knzo25 Awaiting requested review from knzo25 knzo25 is a code owner

@miursh miursh Awaiting requested review from miursh miursh is a code owner

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi is a code owner

Assignees
No one assigned
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@manato @knzo25 @yukkysaito @technolojin @dan-dnn