Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(probabilistic_occupancy_grid_map, occupancy_grid_map_outlier_filter): add autoware_ prefix to package name #8183

Merged
merged 7 commits into from
Jul 26, 2024
Merged

refactor(probabilistic_occupancy_grid_map, occupancy_grid_map_outlier_filter): add autoware_ prefix to package name #8183

merged 7 commits into from
Jul 26, 2024

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Jul 25, 2024

Description

Update package name of following packages

  • probabilistic_occupancy_grid_map
  • occupancy_grid_map_outlier_filter

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@YoshiRi YoshiRi marked this pull request as ready for review July 25, 2024 04:17
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

YoshiRi added 3 commits July 25, 2024 13:22
@YoshiRi
chore: fix package name probabilistic occupancy grid map
7c2a5f1 
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi
fix: solve launch error
9f188c2 
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi
chore: update occupancy_grid_map_outlier_filter
ae19d16 
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi force-pushed the refactor/prefix_change_occupancy_grid branch from 2f7a2d8 to ae19d16 Compare July 25, 2024 04:25
@technolojin technolojin self-assigned this Jul 25, 2024
technolojin
technolojin approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 25, 2024
badai-nguyen
badai-nguyen approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi enabled auto-merge (squash) July 25, 2024 05:38
@technolojin technolojin disabled auto-merge July 26, 2024 01:08
@technolojin
refactor: rename folder of occupancy_grid_map_outlier_filter
e040015 
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin enabled auto-merge (squash) July 26, 2024 01:23
@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.33%. Comparing base (fc338c5) to head (e040015).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8183      +/-   ##
==========================================
+ Coverage   29.25%   29.33%   +0.08%     
==========================================
  Files        1600     1628      +28     
  Lines      117736   119161    +1425     
  Branches    50717    51268     +551     
==========================================
+ Hits        34441    34958     +517     
- Misses      74082    74895     +813     
- Partials     9213     9308      +95
Flag Coverage Δ *Carryforward flag
differential 13.34% <ø> (?)
total 29.25% <ø> (ø) Carriedforward from fc338c5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin merged commit 287e753 into autowarefoundation:main Jul 26, 2024
28 of 30 checks passed
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 26, 2024
@YoshiRi @pre-commit-ci @technolojin
refactor(probabilistic_occupancy_grid_map, occupancy_grid_map_outlier…
7697085 
…_filter): add autoware_ prefix to package name (autowarefoundation#8183)

* chore: fix package name probabilistic occupancy grid map

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: solve launch error

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* chore: update occupancy_grid_map_outlier_filter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* style(pre-commit): autofix

* refactor: update package name to autoware_probabilistic_occupancy_grid_map on a test

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename folder of occupancy_grid_map_outlier_filter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Taekjin LEE <taekjin.lee@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jul 28, 2024
@YoshiRi @pre-commit-ci
@technolojin @a-maumau
refactor(probabilistic_occupancy_grid_map, occupancy_grid_map_outlier…
326e008 
…_filter): add autoware_ prefix to package name (autowarefoundation#8183)

* chore: fix package name probabilistic occupancy grid map

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: solve launch error

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* chore: update occupancy_grid_map_outlier_filter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* style(pre-commit): autofix

* refactor: update package name to autoware_probabilistic_occupancy_grid_map on a test

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename folder of occupancy_grid_map_outlier_filter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Taekjin LEE <taekjin.lee@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
@YoshiRi @pre-commit-ci
@technolojin @esteve
refactor(probabilistic_occupancy_grid_map, occupancy_grid_map_outlier…
0154971 
…_filter): add autoware_ prefix to package name (autowarefoundation#8183)

* chore: fix package name probabilistic occupancy grid map

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: solve launch error

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* chore: update occupancy_grid_map_outlier_filter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* style(pre-commit): autofix

* refactor: update package name to autoware_probabilistic_occupancy_grid_map on a test

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: rename folder of occupancy_grid_map_outlier_filter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Taekjin LEE <taekjin.lee@tier4.jp>
@esteve esteve mentioned this pull request Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@soblin soblin soblin approved these changes

@kyoichi-sugahara kyoichi-sugahara kyoichi-sugahara approved these changes

@technolojin technolojin technolojin approved these changes

@badai-nguyen badai-nguyen badai-nguyen approved these changes

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@amc-nu amc-nu Awaiting requested review from amc-nu amc-nu is a code owner

@miursh miursh Awaiting requested review from miursh miursh is a code owner

@Shin-kyoto Shin-kyoto Awaiting requested review from Shin-kyoto Shin-kyoto is a code owner

Assignees

@technolojin technolojin

Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YoshiRi @yukkysaito @soblin @kyoichi-sugahara @technolojin @badai-nguyen