Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(image_projection_based_fusion)!: add package name prefix of autoware_ #8162

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jul 23, 2024

Description

This PR adds the autoware_ prefix to the package name.

Changes are as following.

  1. Folder name (appears as file renaming)
  2. Package names in CMakeLists.txt, package.xml
  3. README.md
  4. Launch files $(find-pkg-share ...)
  5. .github/CODEOWNERS

This PR do not contains any logic change.

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…ection_based_fusion

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 23, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.02%. Comparing base (f47aa2a) to head (cff8647).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8162      +/-   ##
==========================================
- Coverage   29.12%   29.02%   -0.11%     
==========================================
  Files        1609     1630      +21     
  Lines      118136   119514    +1378     
  Branches    50850    51451     +601     
==========================================
+ Hits        34406    34687     +281     
- Misses      74553    75588    +1035     
- Partials     9177     9239      +62     
Flag Coverage Δ *Carryforward flag
differential 4.56% <ø> (?)
total 29.12% <ø> (+<0.01%) ⬆️ Carriedforward from f47aa2a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin marked this pull request as ready for review July 23, 2024 11:50
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Note: make sure that the update of related repos like this is also neccessary.

@technolojin technolojin merged commit 065e021 into autowarefoundation:main Jul 24, 2024
41 of 43 checks passed
Shin-kyoto pushed a commit to tier4/autoware.universe that referenced this pull request Jul 25, 2024
…autoware_ (autowarefoundation#8162)

refactor: rename image_projection_based_fusion to autoware_image_projection_based_fusion

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin deleted the refactor/prefix-image_projection_based_fusion branch July 26, 2024 02:19
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 26, 2024
…autoware_ (autowarefoundation#8162)

refactor: rename image_projection_based_fusion to autoware_image_projection_based_fusion

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…autoware_ (autowarefoundation#8162)

refactor: rename image_projection_based_fusion to autoware_image_projection_based_fusion

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants