Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(traffic_light_*)!: add package name prefix of autoware_ #8159

Merged
merged 6 commits into from
Jul 25, 2024
Merged

refactor(traffic_light_*)!: add package name prefix of autoware_ #8159

merged 6 commits into from
Jul 25, 2024

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jul 23, 2024 •
edited by miursh
Loading

Description

This PR adds the autoware_ prefix to the package name.

  • traffic_light_fine_detector
  • traffic_light_multi_camera_fusion
  • traffic_light_occlusion_predictor
  • traffic_light_classifier
  • traffic_light_map_based_detector
  • traffic_light_visualization

Changes are as following.

  1. Folder name (appears as file renaming)
  2. Package names in CMakeLists.txt, package.xml
  3. README.md
  4. Launch files $(find-pkg-share ...)
  5. .github/CODEOWNERS

This PR do not contains any logic change.

Related links

Part of: autowarefoundation/autoware#4569

Related PRs

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin force-pushed the refactor/prefix-traffic_light-group branch from 1337b87 to cf29d92 Compare July 23, 2024 05:24
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.88%. Comparing base (e46c927) to head (d2bee81).
Report is 1 commits behind head on main.

Files Patch % Lines
...on/src/traffic_light_roi_visualizer/shape_draw.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8159      +/-   ##
==========================================
- Coverage   29.22%   28.88%   -0.35%     
==========================================
  Files        1596     1615      +19     
  Lines      117690   119087    +1397     
  Branches    50706    50924     +218     
==========================================
  Hits        34400    34400              
- Misses      74075    75472    +1397     
  Partials     9215     9215
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.22% <ø> (ø) Carriedforward from e46c927

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin marked this pull request as ready for review July 23, 2024 23:51
@technolojin technolojin force-pushed the refactor/prefix-traffic_light-group branch from 2f2e32f to 71d5365 Compare July 24, 2024 01:59
yukkysaito
yukkysaito approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

YoshiRi
YoshiRi approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you fix conflict?

@miursh
Copy link
Contributor

miursh commented Jul 25, 2024

@technolojin
Could you please add links to the related links section for PRs to launchers (i.e. jetson_launch, autoware_launch, etc) using these packages

@technolojin
Copy link
Contributor Author

technolojin commented Jul 25, 2024 •
edited
Loading

@miursh

webauto-ci https://github.com/tier4/pilot-auto/pull/868

jetson_launcher (TIER IV INTERNAL) - in a branch
https://github.com/tier4/jetson_launcher/tree/refactor/autoware-prefix

autoware_launcher, aip_laucher... : no changes (abstracted in tier4_perception_launch)

@technolojin
chore: rename traffic_light_fine_detector to autoware_traffic_light_f…
9bf341b 
…ine_detector

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin
chore: rename traffic_light_multi_camera_fusion to autoware_traffic_l…
8b2b802 
…ight_multi_camera_fusion

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin
chore: rename traffic_light_occlusion_predictor to autoware_traffic_l…
fda5baa 
…ight_occlusion_predictor

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin
chore: rename traffic_light_classifier to autoware_traffic_light_clas…
c9b2c2b 
…sifier

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin
chore: rename traffic_light_map_based_detector to autoware_traffic_li…
63b412e 
…ght_map_based_detector

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the refactor/prefix-traffic_light-group branch from 71d5365 to 6cd04b4 Compare July 25, 2024 00:49
@technolojin
chore: rename traffic_light_visualization to autoware_traffic_light_v…
d2bee81 
…isualization

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the refactor/prefix-traffic_light-group branch from 6cd04b4 to d2bee81 Compare July 25, 2024 01:01
@technolojin technolojin merged commit f808124 into autowarefoundation:main Jul 25, 2024
30 of 32 checks passed
@technolojin technolojin deleted the refactor/prefix-traffic_light-group branch July 25, 2024 02:16
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 26, 2024
@technolojin
refactor(traffic_light_*)!: add package name prefix of autoware_ (aut…
fdef9ea 
…owarefoundation#8159)

* chore: rename traffic_light_fine_detector to autoware_traffic_light_fine_detector

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: rename traffic_light_multi_camera_fusion to autoware_traffic_light_multi_camera_fusion

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: rename traffic_light_occlusion_predictor to autoware_traffic_light_occlusion_predictor

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: rename traffic_light_classifier to autoware_traffic_light_classifier

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: rename traffic_light_map_based_detector to autoware_traffic_light_map_based_detector

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: rename traffic_light_visualization to autoware_traffic_light_visualization

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
@technolojin @esteve
refactor(traffic_light_*)!: add package name prefix of autoware_ (aut…
e59e7ca 
…owarefoundation#8159)

* chore: rename traffic_light_fine_detector to autoware_traffic_light_fine_detector

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: rename traffic_light_multi_camera_fusion to autoware_traffic_light_multi_camera_fusion

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: rename traffic_light_occlusion_predictor to autoware_traffic_light_occlusion_predictor

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: rename traffic_light_classifier to autoware_traffic_light_classifier

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: rename traffic_light_map_based_detector to autoware_traffic_light_map_based_detector

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* chore: rename traffic_light_visualization to autoware_traffic_light_visualization

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@esteve esteve mentioned this pull request Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@YoshiRi YoshiRi YoshiRi approved these changes

@miursh miursh miursh approved these changes

@tzhong518 tzhong518 Awaiting requested review from tzhong518 tzhong518 is a code owner

@Shin-kyoto Shin-kyoto Awaiting requested review from Shin-kyoto Shin-kyoto is a code owner

Assignees

@technolojin technolojin

@tzhong518 tzhong518

Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@technolojin @miursh @yukkysaito @YoshiRi @tzhong518