fix(fault_injection): fix empty hardware_id

[h-ohta]

Description

In fault_injection node, all diags had empty hardware_id.
This is because hardware_id was replaced with the following value in updateEventDiag().

autoware.universe/simulator/fault_injection/include/fault_injection/diagnostic_storage.hpp

Line 42 in 377b7ff

status.hardware_id = "";

I fix it.

Review Procedure

Confirm some fault injection diag has fault injection as hardware_id like following image in rqt_robot_monitor.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Merging #814 (0c48923) into main (d1cb17e) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #814   +/-   ##
=====================================
  Coverage   9.66%   9.66%           
=====================================
  Files        908     908           
  Lines      56560   56560           
  Branches    6830    6830           
=====================================
  Hits        5465    5465           
  Misses     46593   46593           
  Partials    4502    4502           

Flag	Coverage Δ		*Carryforward flag
differential	40.74% <ø> (?)
total	9.66% <ø> (ø)		Carriedforward from d1cb17e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...ion/include/fault_injection/diagnostic_storage.hpp	53.84% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0a4e75...0c48923. Read the comment docs.

[KeisukeShima]

@h-ohta
Small question:
I heard from @kenji-miyake before that Autoware didn't use hardware_id. Do you use it in your use case?

[kenji-miyake]

@KeisukeShima You should set at least none. I personally think the node name is acceptable.
https://github.com/ros/diagnostics/blob/31343dbbb8c2d1380768ed101a9d32f2df6aaee1/diagnostic_updater/diagnostic_updater/example.py#L142-L143

[KeisukeShima]

@kenji-miyake Thanks for your comment.
LGTM