feat(autonomous_emergency_braking): add some tests to aeb #8126

danielsanchezaran · 2024-07-22T07:48:20Z

Description

This PR adds several tests to the AEB module. It does not cover every possible function but aims to get a 50% coverage.

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions · 2024-07-22T07:48:36Z

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

codecov · 2024-07-22T08:19:27Z

Codecov Report

Attention: Patch coverage is 68.70748% with 46 lines in your changes missing coverage. Please review.

Project coverage is 3.42%. Comparing base (3d849e9) to head (ac54fea).
Report is 975 commits behind head on main.

Files	Patch %	Lines
...utoware_autonomous_emergency_braking/test/test.cpp	67.39%	17 Missing and 28 partials ⚠️
...utoware_autonomous_emergency_braking/src/utils.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #8126       +/-   ##
==========================================
- Coverage   15.09%   3.42%   -11.67%     
==========================================
  Files        1967     145     -1822     
  Lines      135941   14290   -121651     
  Branches    42122    1881    -40241     
==========================================
- Hits        20520     490    -20030     
+ Misses      92700   13735    -78965     
+ Partials    22721      65    -22656

Flag	Coverage Δ
differential	`3.42% <68.70%> (?)`
total	`?`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kyoichi-sugahara · 2024-08-02T01:00:09Z

launch/tier4_control_launch/launch/control.launch.xml

@@ -192,7 +192,6 @@
        <remap from="~/input/pointcloud" to="/perception/obstacle_segmentation/pointcloud"/>
        <remap from="~/input/velocity" to="/vehicle/status/velocity_status"/>
        <remap from="~/input/imu" to="/sensing/imu/imu_data"/>
-        <remap from="~/input/odometry" to="/localization/kinematic_state"/>


@danielsanchezaran
This change is intended?

@kyoichi-sugahara yes, that topic is not used

kyoichi-sugahara · 2024-08-02T01:02:35Z

@danielsanchezaran
Implementation itself looks to me 👍 Thanks.
Could you also share the coverage after implemeting those test?
I expect following info and if you don't know how to check those info let me know.

danielsanchezaran · 2024-08-02T03:57:54Z

@danielsanchezaran Implementation itself looks to me 👍 Thanks. Could you also share the coverage after implemeting those test? I expect following info and if you don't know how to check those info let me know.

Sure,

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

This reverts commit b5ef11b. Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

kyoichi-sugahara

Thank you LGTM!

…undation#8126) * add initial tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add more tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * more tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * WIP add publishing and test subscription Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add more tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix lint cmake Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * WIP tf topic Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Revert "WIP tf topic" This reverts commit b5ef11b. Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add path crop test Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add test for transform object Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add briefs Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete repeated test Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>

…undation#8126) * add initial tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add more tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * more tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * WIP add publishing and test subscription Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add more tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix lint cmake Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * WIP tf topic Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Revert "WIP tf topic" This reverts commit b5ef11b. Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add path crop test Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add test for transform object Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add briefs Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete repeated test Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

…undation#8126) * add initial tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add more tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * more tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * WIP add publishing and test subscription Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add more tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix lint cmake Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * WIP tf topic Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Revert "WIP tf topic" This reverts commit b5ef11b. Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add path crop test Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add test for transform object Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add briefs Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete repeated test Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>

…undation#8126) * add initial tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add more tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * more tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * WIP add publishing and test subscription Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add more tests Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix lint cmake Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * WIP tf topic Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Revert "WIP tf topic" This reverts commit b5ef11b. Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add path crop test Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add test for transform object Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add briefs Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete repeated test Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

danielsanchezaran added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 22, 2024

github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 22, 2024

danielsanchezaran added tag:run-clang-tidy-differential and removed component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 22, 2024

github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 22, 2024

danielsanchezaran assigned danielsanchezaran and kyoichi-sugahara Jul 22, 2024

xmfcx removed the tag:run-clang-tidy-differential label Jul 23, 2024

danielsanchezaran force-pushed the feat/add-tests-to-aeb branch from 83cc0b2 to 5119628 Compare July 29, 2024 02:59

danielsanchezaran marked this pull request as ready for review July 29, 2024 02:59

danielsanchezaran requested review from TakaHoribe, takayuki5168, kyoichi-sugahara, soblin and tkimura4 as code owners July 29, 2024 02:59

danielsanchezaran force-pushed the feat/add-tests-to-aeb branch from 5119628 to 1e521ae Compare July 29, 2024 03:23

kyoichi-sugahara reviewed Aug 2, 2024

View reviewed changes

danielsanchezaran added 6 commits August 2, 2024 13:08

add initial tests

c6f7b02

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

add more tests

1990fdb

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

more tests

e8d0521

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

WIP add publishing and test subscription

4ac7db8

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

add more tests

0758654

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

fix lint cmake

e095a2f

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

danielsanchezaran added 6 commits August 2, 2024 13:08

WIP tf topic

8966a95

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

Revert "WIP tf topic"

0f06728

This reverts commit b5ef11b. Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

add path crop test

6efde69

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

add test for transform object

59cc569

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

add briefs

8f44512

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

delete repeated test

1553f1b

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

danielsanchezaran force-pushed the feat/add-tests-to-aeb branch from 1e521ae to 1553f1b Compare August 2, 2024 04:30

kyoichi-sugahara approved these changes Aug 2, 2024

View reviewed changes

takayuki5168 approved these changes Aug 2, 2024

View reviewed changes

Merge branch 'main' into feat/add-tests-to-aeb

ac54fea

danielsanchezaran merged commit 87df6ad into autowarefoundation:main Aug 2, 2024
30 checks passed

danielsanchezaran deleted the feat/add-tests-to-aeb branch August 2, 2024 09:14

danielsanchezaran mentioned this pull request Nov 14, 2024

feat(autonomous_emergency_braking): cherry pick/aeb latest to v4.0.0 tier4/autoware.universe#1643

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(autonomous_emergency_braking): add some tests to aeb #8126

feat(autonomous_emergency_braking): add some tests to aeb #8126

danielsanchezaran commented Jul 22, 2024 •

edited

Loading

github-actions bot commented Jul 22, 2024 •

edited

Loading

codecov bot commented Jul 22, 2024 •

edited

Loading

kyoichi-sugahara Aug 2, 2024

danielsanchezaran Aug 2, 2024

kyoichi-sugahara commented Aug 2, 2024

danielsanchezaran commented Aug 2, 2024

kyoichi-sugahara left a comment

feat(autonomous_emergency_braking): add some tests to aeb #8126

feat(autonomous_emergency_braking): add some tests to aeb #8126

Conversation

danielsanchezaran commented Jul 22, 2024 • edited Loading

Description

Related links

How was this PR tested?

Notes for reviewers

Interface changes

Effects on system behavior

github-actions bot commented Jul 22, 2024 • edited Loading

codecov bot commented Jul 22, 2024 • edited Loading

Codecov Report

kyoichi-sugahara Aug 2, 2024

Choose a reason for hiding this comment

danielsanchezaran Aug 2, 2024

Choose a reason for hiding this comment

kyoichi-sugahara commented Aug 2, 2024

danielsanchezaran commented Aug 2, 2024

kyoichi-sugahara left a comment

Choose a reason for hiding this comment

danielsanchezaran commented Jul 22, 2024 •

edited

Loading

github-actions bot commented Jul 22, 2024 •

edited

Loading

codecov bot commented Jul 22, 2024 •

edited

Loading