Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(qp_interface): clean up the code #8029

Merged
merged 4 commits into from
Jul 13, 2024

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 13, 2024

Description

This package is not used by any package in Autoware currently.

  • Changed namespace
    • qp -> autoware::common
  • Changed the member variable expression
    • m_XXX -> XXX_ (just my preference according to most of the planning and control packages)
  • Added isSolved function
    • Currently, there is no way for the node side to know whether the optimization was successful.
  • Minor change to constructors, member functions

Related links

How was this PR tested?

unit test

Notes for reviewers

OSQPInterface in the qp_interface package is not well organized since it's almost just copied from the osqp_interface package.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 13, 2024
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jul 13, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 38.82784% with 167 lines in your changes missing coverage. Please review.

Project coverage is 28.94%. Comparing base (d571fc4) to head (007a5c4).
Report is 2 commits behind head on main.

Files Patch % Lines
common/qp_interface/test/test_csc_matrix_conv.cpp 0.00% 0 Missing and 97 partials ⚠️
common/qp_interface/src/osqp_interface.cpp 52.68% 38 Missing and 6 partials ⚠️
common/qp_interface/src/proxqp_interface.cpp 53.84% 15 Missing and 3 partials ⚠️
common/qp_interface/test/test_osqp_interface.cpp 80.76% 0 Missing and 5 partials ⚠️
common/qp_interface/test/test_proxqp_interface.cpp 75.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8029   +/-   ##
=======================================
  Coverage   28.93%   28.94%           
=======================================
  Files        1602     1602           
  Lines      117296   117314   +18     
  Branches    50364    50373    +9     
=======================================
+ Hits        33941    33955   +14     
- Misses      74191    74192    +1     
- Partials     9164     9167    +3     
Flag Coverage Δ *Carryforward flag
differential 55.80% <38.82%> (?)
total 28.92% <ø> (-0.02%) ⬇️ Carriedforward from d571fc4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 marked this pull request as ready for review July 13, 2024 05:22
@takayuki5168 takayuki5168 merged commit 0eae67c into autowarefoundation:main Jul 13, 2024
46 of 47 checks passed
@takayuki5168 takayuki5168 deleted the refactor/qp-interface branch July 13, 2024 05:56
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
* refactor qp_interface

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* variable names: m_XXX -> XXX_

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 8, 2024
* refactor qp_interface

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* variable names: m_XXX -> XXX_

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
TetsuKawa pushed a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2025
* refactor qp_interface

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* variable names: m_XXX -> XXX_

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant