-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(qp_interface): clean up the code #8029
refactor(qp_interface): clean up the code #8029
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8029 +/- ##
=======================================
Coverage 28.93% 28.94%
=======================================
Files 1602 1602
Lines 117296 117314 +18
Branches 50364 50373 +9
=======================================
+ Hits 33941 33955 +14
- Misses 74191 74192 +1
- Partials 9164 9167 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* refactor qp_interface Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * variable names: m_XXX -> XXX_ Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* refactor qp_interface Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * variable names: m_XXX -> XXX_ Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* refactor qp_interface Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * variable names: m_XXX -> XXX_ Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Description
This package is not used by any package in Autoware currently.
qp
->autoware::common
m_XXX
->XXX_
(just my preference according to most of the planning and control packages)isSolved
functionRelated links
How was this PR tested?
unit test
Notes for reviewers
OSQPInterface in the
qp_interface
package is not well organized since it's almost just copied from theosqp_interface
package.Interface changes
None.
Effects on system behavior
None.