refactor(static_avoidance): modify getAdjacentLane function #7843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Go Sakayori <gsakayori@gmail.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
satoshi-ota
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
It Looks good to me. Thanks 👍
https://evaluation.tier4.jp/evaluation/reports/2231c1a3-cf06-55fd-b04e-e251873acdc3?project_id=prd_jt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7843 +/- ##
==========================================
- Coverage 28.68% 28.67% -0.01%
==========================================
Files 1587 1588 +1
Lines 116303 116328 +25
Branches 49656 49663 +7
==========================================
+ Hits 33356 33360 +4
- Misses 73868 73890 +22
+ Partials 9079 9078 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…foundation#7843) add getLeftOppositeLanelers in getAdjacentLane function Signed-off-by: Go Sakayori <gsakayori@gmail.com> Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…foundation#7843) add getLeftOppositeLanelers in getAdjacentLane function Signed-off-by: Go Sakayori <gsakayori@gmail.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
add getLeftOppositeLanelers in getAdjacentLane function Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…foundation#7843) add getLeftOppositeLanelers in getAdjacentLane function Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Left opposite lanes were not considered in the getAdjacentLane function. This PR adds the left opposite lanes inside the function.
Related links
None
How was this PR tested?
Internal test
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
Static obstacle avoidance should cover wider scenes.