Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(imu_corrector): fix shadowFunction #7839

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jul 4, 2024

Description

This is a fix based on cppcheck shadowFunction warning

sensing/imu_corrector/src/gyro_bias_estimator.cpp:54:8: style: Local variable 'timer_callback' shadows outer function [shadowFunction]
  auto timer_callback = std::bind(&GyroBiasEstimator::timer_callback, this);
       ^
sensing/imu_corrector/src/gyro_bias_estimator.hpp:51:8: note: Shadowed declaration
  void timer_callback();
       ^
sensing/imu_corrector/src/gyro_bias_estimator.cpp:54:8: note: Shadow variable
  auto timer_callback = std::bind(&GyroBiasEstimator::timer_callback, this);
       ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc self-assigned this Jul 4, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.67%. Comparing base (b54d57d) to head (72e4b77).
Report is 9 commits behind head on main.

Files Patch % Lines
sensing/imu_corrector/src/gyro_bias_estimator.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7839      +/-   ##
==========================================
- Coverage   28.67%   28.67%   -0.01%     
==========================================
  Files        1587     1587              
  Lines      116303   116309       +6     
  Branches    49651    49654       +3     
==========================================
  Hits        33354    33354              
- Misses      73864    73870       +6     
  Partials     9085     9085              
Flag Coverage Δ *Carryforward flag
differential 3.85% <0.00%> (?)
total 28.67% <ø> (+<0.01%) ⬆️ Carriedforward from b54d57d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TaikiYamada4 TaikiYamada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it! LGTM.

@veqcc veqcc merged commit 55bedee into autowarefoundation:main Jul 5, 2024
39 checks passed
@veqcc veqcc deleted the fix/cppcheck_shadowFunction3 branch July 5, 2024 00:32
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants