fix(diagnostic_graph_aggregator): fix shadowFunction

[veqcc]

Description

This is a fix based on cppcheck shadowFunction warnings

system/diagnostic_graph_aggregator/src/common/graph/config.cpp:71:14: style: Local variable 'paths' shadows outer function [shadowFunction]
  const auto paths = tree.optional("files").children("files");
             ^
system/diagnostic_graph_aggregator/src/common/graph/config.hpp:73:16: note: Shadowed declaration
  const auto & paths() const { return paths_; }
               ^
system/diagnostic_graph_aggregator/src/common/graph/config.cpp:71:14: note: Shadow variable
  const auto paths = tree.optional("files").children("files");
             ^

system/diagnostic_graph_aggregator/src/common/graph/data.cpp:38:14: style: Local variable 'path' shadows outer function [shadowFunction]
  const auto path = path_.field(name);
             ^
system/diagnostic_graph_aggregator/src/common/graph/data.hpp:39:16: note: Shadowed declaration
  const auto & path() const { return path_; }
               ^
system/diagnostic_graph_aggregator/src/common/graph/data.cpp:38:14: note: Shadow variable
  const auto path = path_.field(name);
             ^
system/diagnostic_graph_aggregator/src/common/graph/data.cpp:50:14: style: Local variable 'path' shadows outer function [shadowFunction]
  const auto path = path_.field(name);
             ^
system/diagnostic_graph_aggregator/src/common/graph/data.hpp:39:16: note: Shadowed declaration
  const auto & path() const { return path_; }
               ^
system/diagnostic_graph_aggregator/src/common/graph/data.cpp:50:14: note: Shadow variable
  const auto path = path_.field(name);
             ^

system/diagnostic_graph_aggregator/src/common/graph/units.cpp:88:14: style: Local variable 'name' shadows outer function [shadowFunction]
  const auto name = unit.data().required("name").text();
             ^
system/diagnostic_graph_aggregator/src/common/graph/units.hpp:98:15: note: Shadowed declaration
  std::string name() const { return struct_.name; }
              ^
system/diagnostic_graph_aggregator/src/common/graph/units.cpp:88:14: note: Shadow variable
  const auto name = unit.data().required("name").text();
             ^

If you do not like the modified variable names, please fix them!

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.67%. Comparing base (b54d57d) to head (4ee94bd).
Report is 9 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7838   +/-   ##
=======================================
  Coverage   28.67%   28.67%           
=======================================
  Files        1587     1587           
  Lines      116303   116303           
  Branches    49651    49651           
=======================================
  Hits        33354    33354           
  Misses      73864    73864           
  Partials     9085     9085           

Flag	Coverage Δ		*Carryforward flag
differential	64.67% <100.00%> (?)
total	28.67% <ø> (-0.01%)	⬇️	Carriedforward from ddc138c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[isamu-takagi]

LGTM