Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(probabilistic_occupancy_grid_map): fix noExplicitConstructor #7811

Merged
merged 1 commit into from
Jul 4, 2024
Merged

fix(probabilistic_occupancy_grid_map): fix noExplicitConstructor #7811

merged 1 commit into from
Jul 4, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jul 3, 2024

Description

This is a fix based on cppcheck noExplicitConstructor warnings

perception/probabilistic_occupancy_grid_map/src/pointcloud_based_occupancy_grid_map/occupancy_grid_map_projective.cpp:78:5: style: Struct 'BinInfo3D' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
    BinInfo3D(
    ^

perception/probabilistic_occupancy_grid_map/src/fusion/single_frame_fusion_policy.cpp:174:3: style: Struct 'dempsterShaferOccupancy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  dempsterShaferOccupancy(double occupied_probability)
  ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@veqcc
fix(probabilistic_occupancy_grid_map): fix noExplicitConstructor
4271079 
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@veqcc veqcc self-assigned this Jul 3, 2024
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 3, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.55%. Comparing base (fbbc44c) to head (4271079).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7811      +/-   ##
==========================================
- Coverage   28.55%   28.55%   -0.01%     
==========================================
  Files        1586     1586              
  Lines      115879   115886       +7     
  Branches    49384    49387       +3     
==========================================
+ Hits        33093    33094       +1     
- Misses      73823    73830       +7     
+ Partials     8963     8962       -1
Flag Coverage Δ *Carryforward flag
differential 11.13% <ø> (?)
total 28.55% <ø> (ø) Carriedforward from fbbc44c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc veqcc marked this pull request as ready for review July 3, 2024 14:04
yukkysaito
yukkysaito approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veqcc veqcc merged commit 2705eff into autowarefoundation:main Jul 4, 2024
39 checks passed
@veqcc veqcc deleted the fix/no_explicit_constructor branch July 4, 2024 14:29
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
@veqcc @palas21
fix(probabilistic_occupancy_grid_map): fix noExplicitConstructor (aut…
7bb341b 
…owarefoundation#7811)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
@veqcc @tby-udel
fix(probabilistic_occupancy_grid_map): fix noExplicitConstructor (aut…
6b6ce6e 
…owarefoundation#7811)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@veqcc
fix(probabilistic_occupancy_grid_map): fix noExplicitConstructor (#7811)
ea91933 
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
@veqcc @Ariiees
fix(probabilistic_occupancy_grid_map): fix noExplicitConstructor (aut…
90e8b6e 
…owarefoundation#7811)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@soblin soblin Awaiting requested review from soblin

@YoshiRi YoshiRi Awaiting requested review from YoshiRi

Assignees

@veqcc veqcc

Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veqcc @yukkysaito