fix(static_centerline_generator): save_map only once #7770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7770 +/- ##
=========================================
- Coverage 15.09% 6.90% -8.20%
=========================================
Files 1967 437 -1530
Lines 135941 36550 -99391
Branches 42122 5414 -36708
=========================================
- Hits 20520 2523 -17997
+ Misses 92700 33760 -58940
+ Partials 22721 267 -22454
☔ View full report in Codecov by Sentry. |
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 1, 2024
…ion#7770) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
4 tasks
mitukou1109
pushed a commit
to mitukou1109/autoware.universe
that referenced
this pull request
Jul 2, 2024
…ion#7770) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…ion#7770) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…ion#7770) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Saving the map twice by centerline_updater_helper.py did not work well as written in the comment of the changes.
This PR suppress the usage.
Related links
How was this PR tested?
Unit test passed.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.