Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(static_centerline_optimizer): clean up the code #7756

Merged

Conversation

takayuki5168
Copy link
Contributor

Description

Update rviz config, remove unnecessary lines and refactor the function's name.

Related links

How was this PR tested?

Unit test passed.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 30, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 30, 2024
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 6.90%. Comparing base (3d849e9) to head (daa1add).
Report is 546 commits behind head on main.

Files Patch % Lines
...generator/src/static_centerline_generator_node.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main   #7756      +/-   ##
=========================================
- Coverage   15.09%   6.90%   -8.20%     
=========================================
  Files        1967     437    -1530     
  Lines      135941   36548   -99393     
  Branches    42122    5409   -36713     
=========================================
- Hits        20520    2523   -17997     
+ Misses      92700   33758   -58942     
+ Partials    22721     267   -22454     
Flag Coverage Δ
differential 6.90% <50.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 marked this pull request as ready for review July 1, 2024 07:30
@takayuki5168 takayuki5168 requested a review from kosuke55 as a code owner July 1, 2024 07:30
@takayuki5168 takayuki5168 merged commit b3c327f into autowarefoundation:main Jul 1, 2024
36 of 39 checks passed
@takayuki5168 takayuki5168 deleted the fix/static-centerline-update branch July 1, 2024 07:31
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Jul 1, 2024
…ndation#7756)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
…ndation#7756)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…ndation#7756)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…ndation#7756)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants