Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ground_segmentation)!: fix namespace and directory structure #7744

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jun 28, 2024

Description

This PR puts headers in the autoware namespace.

Additional works

  1. Align directory structure to follow the coding guidelines.
  2. Clean unused dependencies LIST

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.
TIER IV INTERNAL

Notes for reviewers

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 28, 2024
Copy link

github-actions bot commented Jun 28, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

technolojin and others added 4 commits July 3, 2024 17:35
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the refactor/namespace-ground_segmentation branch 2 times, most recently from 267ec87 to 438316c Compare July 3, 2024 08:43
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the refactor/namespace-ground_segmentation branch from 438316c to 1669bf8 Compare July 3, 2024 08:56
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 3, 2024
@technolojin technolojin enabled auto-merge (squash) July 3, 2024 09:02
@technolojin technolojin merged commit f796041 into autowarefoundation:main Jul 3, 2024
32 of 33 checks passed
@technolojin technolojin deleted the refactor/namespace-ground_segmentation branch July 9, 2024 04:06
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…autowarefoundation#7744)

* refactor: update namespace in ground_segmentation files

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update namespace in ground_segmentation files

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update ground_segmentation namespace and file structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

* refactor: update ground_segmentation plugin names scheme

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update ransac tester

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…autowarefoundation#7744)

* refactor: update namespace in ground_segmentation files

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update namespace in ground_segmentation files

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update ground_segmentation namespace and file structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

* refactor: update ground_segmentation plugin names scheme

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update ransac tester

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…#7744)

* refactor: update namespace in ground_segmentation files

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update namespace in ground_segmentation files

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update ground_segmentation namespace and file structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

* refactor: update ground_segmentation plugin names scheme

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update ransac tester

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…autowarefoundation#7744)

* refactor: update namespace in ground_segmentation files

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update namespace in ground_segmentation files

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update ground_segmentation namespace and file structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

* refactor: update ground_segmentation plugin names scheme

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor: update ransac tester

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants