Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(autonomous_emergency_braking): apply clangd suggestions to aeb #7703

Merged
merged 2 commits into from
Jun 28, 2024
Merged

chore(autonomous_emergency_braking): apply clangd suggestions to aeb #7703

merged 2 commits into from
Jun 28, 2024

Conversation

danielsanchezaran
Copy link
Contributor

Description

Apply changes suggested by clangd

Related links

Parent Issue:

  • Link

How was this PR tested?

PSim

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@danielsanchezaran
apply clangd suggestions
322b117 
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Jun 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@danielsanchezaran danielsanchezaran marked this pull request as ready for review June 26, 2024 06:19
@danielsanchezaran danielsanchezaran added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 26, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (507e3f4) to head (0da098c).
Report is 154 commits behind head on main.

Files Patch % Lines
...ude/autoware/autonomous_emergency_braking/node.hpp 0.00% 5 Missing ⚠️
...utoware_autonomous_emergency_braking/src/utils.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #7703       +/-   ##
==========================================
- Coverage   14.84%   0.00%   -14.85%     
==========================================
  Files        1999     118     -1881     
  Lines      139163   12776   -126387     
  Branches    43716    1379    -42337     
==========================================
- Hits        20661       0    -20661     
+ Misses      95731   12776    -82955     
+ Partials    22771       0    -22771
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran
add maintainer
0da098c 
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 27, 2024
@danielsanchezaran danielsanchezaran merged commit cd86f71 into autowarefoundation:main Jun 28, 2024
29 of 31 checks passed
@danielsanchezaran danielsanchezaran deleted the refactor/aeb-clang-tidy branch June 28, 2024 06:53
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
@danielsanchezaran @mitukou1109
chore(autonomous_emergency_braking): apply clangd suggestions to aeb (a…
a86edad 
…utowarefoundation#7703)

* apply clangd suggestions

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add maintainer

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
@danielsanchezaran @palas21
chore(autonomous_emergency_braking): apply clangd suggestions to aeb (a…
6f17823 
…utowarefoundation#7703)

* apply clangd suggestions

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add maintainer

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
@danielsanchezaran @tby-udel
chore(autonomous_emergency_braking): apply clangd suggestions to aeb (a…
6c37549 
…utowarefoundation#7703)

* apply clangd suggestions

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add maintainer

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@danielsanchezaran
chore(autonomous_emergency_braking): apply clangd suggestions to aeb (#…
7f5204e 
…7703)

* apply clangd suggestions

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add maintainer

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Sep 11, 2024
@danielsanchezaran
chore(autonomous_emergency_braking): apply clangd suggestions to aeb (a…
4e4f19d 
…utowarefoundation#7703)

* apply clangd suggestions

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add maintainer

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 28, 2024
@danielsanchezaran
chore(autonomous_emergency_braking): apply clangd suggestions to aeb (a…
226379f 
…utowarefoundation#7703)

* apply clangd suggestions

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add maintainer

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Nov 14, 2024
@danielsanchezaran
chore(autonomous_emergency_braking): apply clangd suggestions to aeb (a…
a195768 
…utowarefoundation#7703)

* apply clangd suggestions

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add maintainer

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soblin soblin soblin approved these changes

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

Assignees
No one assigned
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielsanchezaran @soblin