Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar_object_tracker): fix duplicateBranch warning #7697

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 26, 2024

Description

This is a fix based on cppcheck duplicateBranch warning

perception/radar_object_tracker/src/tracker/model/linear_motion_tracker.cpp:143:3: style: inconclusive: Found duplicate branches for 'if' and 'else'. [duplicateBranch]
  if (has_acceleration_covariance) {
  ^
perception/radar_object_tracker/src/tracker/model/linear_motion_tracker.cpp:153:5: note: Found duplicate branches for 'if' and 'else'.
  } else {
    ^
perception/radar_object_tracker/src/tracker/model/linear_motion_tracker.cpp:143:3: note: Found duplicate branches for 'if' and 'else'.
  if (has_acceleration_covariance) {
  ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 26, 2024
@veqcc veqcc self-assigned this Jun 26, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 26, 2024
Copy link

github-actions bot commented Jun 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 1.22%. Comparing base (507e3f4) to head (e67ad57).
Report is 148 commits behind head on main.

Files Patch % Lines
...racker/src/tracker/model/linear_motion_tracker.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7697       +/-   ##
==========================================
- Coverage   14.84%   1.22%   -13.63%     
==========================================
  Files        1999      77     -1922     
  Lines      139163    4405   -134758     
  Branches    43716     407    -43309     
==========================================
- Hits        20661      54    -20607     
+ Misses      95731    4330    -91401     
+ Partials    22771      21    -22750     
Flag Coverage Δ
differential 1.22% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It should be fine to remove the comment-out part.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@veqcc veqcc merged commit 641796b into autowarefoundation:main Jun 26, 2024
29 of 31 checks passed
@veqcc veqcc deleted the fix_duplicate_branch2 branch June 26, 2024 05:58
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…ation#7697)

* fix(radar_object_tracker): fix duplicateBranch warning

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* delete comments

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
…ation#7697)

* fix(radar_object_tracker): fix duplicateBranch warning

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* delete comments

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…ation#7697)

* fix(radar_object_tracker): fix duplicateBranch warning

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* delete comments

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…ation#7697)

* fix(radar_object_tracker): fix duplicateBranch warning

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* delete comments

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* fix(radar_object_tracker): fix duplicateBranch warning

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* delete comments

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants