Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_obstacle_avoidance): fix json schema #7692

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

satoshi-ota
Copy link
Contributor

Description

Fix json schema. Previously, mkdocs outputed following error when I opened static obstacle avoidance page.

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs_macros/plugin.py", line 527, in render
    return md_template.render(**page_variables)
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/jinja2/environment.py", line 1304, in render
    self.environment.handle_exception()
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/jinja2/environment.py", line 939, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "<template>", line 1221, in top-level template code
  File "/home/runner/work/autoware.universe/autoware.universe/mkdocs_macros.py", line 72, in json_to_markdown
    return format_json(data)
  File "/home/runner/work/autoware.universe/autoware.universe/mkdocs_macros.py", line 63, in format_json
    markdown_table = tabulate(extract_parameter_info(parameters), headers="keys", tablefmt="github")
  File "/home/runner/work/autoware.universe/autoware.universe/mkdocs_macros.py", line 47, in extract_parameter_info
    if v["type"] != "object":
KeyError: 'type'

Related links

https://autowarefoundation.github.io/autoware.universe/main/planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 26, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@satoshi-ota satoshi-ota added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 26, 2024
Copy link

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-7692/
Modified URLs:

Copy link
Contributor

@go-sakayori go-sakayori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.65%. Comparing base (507e3f4) to head (9200dc2).
Report is 140 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7692       +/-   ##
===========================================
- Coverage   14.84%   13.65%    -1.20%     
===========================================
  Files        1999      255     -1744     
  Lines      139163    26588   -112575     
  Branches    43716     5163    -38553     
===========================================
- Hits        20661     3631    -17030     
+ Misses      95731    22428    -73303     
+ Partials    22771      529    -22242     
Flag Coverage Δ
differential 13.65% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 1cff7ad into autowarefoundation:main Jun 26, 2024
53 of 54 checks passed
@satoshi-ota satoshi-ota deleted the docs/avoidance branch June 26, 2024 00:45
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jul 8, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jul 29, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants