Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_planner_common): fix shadowArgument warning in getDistanceToCrosswalk #7665

Conversation

Koichi98
Copy link
Contributor

Description

src/universe/autoware.universe/planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/utils.cpp:737:36: style: Local variable 'lanelets' shadows outer argument [shadowArgument]
            lanelet::ConstLanelets lanelets = {llt};
                                   ^
src/universe/autoware.universe/planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/utils.cpp:694:61: note: Shadowed declaration
  const Pose & current_pose, const lanelet::ConstLanelets & lanelets,
                                                            ^
src/universe/autoware.universe/planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/utils.cpp:737:36: note: Shadow variable
            lanelet::ConstLanelets lanelets = {llt};
                                   ^

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…g in getDistanceToCrosswalk

Signed-off-by: Koichi Imai <kotty.0704@gmail.com>
@Koichi98 Koichi98 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 24, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 13.08%. Comparing base (507e3f4) to head (a6b6b8d).
Report is 123 commits behind head on main.

Files Patch % Lines
...e_behavior_path_planner_common/src/utils/utils.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7665      +/-   ##
==========================================
- Coverage   14.84%   13.08%   -1.77%     
==========================================
  Files        1999      525    -1474     
  Lines      139163    48896   -90267     
  Branches    43716    11809   -31907     
==========================================
- Hits        20661     6398   -14263     
+ Misses      95731    41550   -54181     
+ Partials    22771      948   -21823     
Flag Coverage Δ
differential 13.08% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Koichi98 Koichi98 merged commit bfcb320 into autowarefoundation:main Jun 25, 2024
38 of 40 checks passed
@Koichi98 Koichi98 deleted the fix_shadowArg_getDistanceToCrosswalk branch June 25, 2024 00:17
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…g in getDistanceToCrosswalk (autowarefoundation#7665)

Signed-off-by: Koichi Imai <kotty.0704@gmail.com>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
…g in getDistanceToCrosswalk (autowarefoundation#7665)

Signed-off-by: Koichi Imai <kotty.0704@gmail.com>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…g in getDistanceToCrosswalk (autowarefoundation#7665)

Signed-off-by: Koichi Imai <kotty.0704@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…g in getDistanceToCrosswalk (#7665)

Signed-off-by: Koichi Imai <kotty.0704@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants