Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(object_range_splitter)!: fix namespace and directory structure #7644

Merged
merged 6 commits into from
Jun 27, 2024
Merged

refactor(object_range_splitter)!: fix namespace and directory structure #7644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fc00067
refactor: refactor object_range_splitter library and node
technolojin Jun 24, 2024
424c5a7
refactor: refactor object_range_splitter library and node
technolojin Jun 24, 2024
69ff98b
refactor: fix the node name
technolojin Jun 25, 2024
4110552
refactor: rename include path
technolojin Jun 25, 2024
a4d84f8
refactor: remove unused dependency on sensor_msgs
technolojin Jun 25, 2024
9357ec9
refactor: move header file to src
technolojin Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions perception/object_range_splitter/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ project(object_range_splitter)
find_package(autoware_cmake REQUIRED)
autoware_package()

ament_auto_add_library(object_range_splitter SHARED
src/node.cpp
ament_auto_add_library(${PROJECT_NAME} SHARED
src/object_range_splitter_node.cpp
)

rclcpp_components_register_node(object_range_splitter
PLUGIN "object_range_splitter::ObjectRangeSplitterNode"
rclcpp_components_register_node(${PROJECT_NAME}
PLUGIN "autoware::object_range_splitter::ObjectRangeSplitterNode"
EXECUTABLE object_range_splitter_node
)

Expand Down
1 change: 0 additions & 1 deletion perception/object_range_splitter/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
<depend>autoware_perception_msgs</depend>
<depend>rclcpp</depend>
<depend>rclcpp_components</depend>
<depend>sensor_msgs</depend>

<test_depend>ament_lint_auto</test_depend>
<test_depend>autoware_lint_common</test_depend>
Expand Down
8 changes: 4 additions & 4 deletions ...eption/object_range_splitter/src/node.cpp → ...litter/src/object_range_splitter_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include "object_range_splitter/node.hpp"
#include "object_range_splitter_node.hpp"

namespace object_range_splitter
namespace autoware::object_range_splitter
{
ObjectRangeSplitterNode::ObjectRangeSplitterNode(const rclcpp::NodeOptions & node_options)
: Node("object_range_splitter_node", node_options)
Expand Down Expand Up @@ -59,7 +59,7 @@
long_range_object_pub_->publish(output_long_range_object_msg);
short_range_object_pub_->publish(output_short_range_object_msg);
}
} // namespace object_range_splitter
} // namespace autoware::object_range_splitter

#include <rclcpp_components/register_node_macro.hpp>
RCLCPP_COMPONENTS_REGISTER_NODE(object_range_splitter::ObjectRangeSplitterNode)
RCLCPP_COMPONENTS_REGISTER_NODE(autoware::object_range_splitter::ObjectRangeSplitterNode)

Check warning on line 65 in perception/object_range_splitter/src/object_range_splitter_node.cpp

View check run for this annotation

Codecov / codecov/patch

perception/object_range_splitter/src/object_range_splitter_node.cpp#L65 

Added line #L65 was not covered by tests
12 changes: 6 additions & 6 deletions ...er/include/object_range_splitter/node.hpp → ...litter/src/object_range_splitter_node.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#ifndef OBJECT_RANGE_SPLITTER__NODE_HPP_
#define OBJECT_RANGE_SPLITTER__NODE_HPP_
#ifndef OBJECT_RANGE_SPLITTER_NODE_HPP_
#define OBJECT_RANGE_SPLITTER_NODE_HPP_

#include <rclcpp/rclcpp.hpp>

#include <autoware_perception_msgs/msg/detected_objects.hpp>
#include "autoware_perception_msgs/msg/detected_objects.hpp"

#include <memory>

namespace object_range_splitter
namespace autoware::object_range_splitter
{
class ObjectRangeSplitterNode : public rclcpp::Node
{
Expand All @@ -42,6 +42,6 @@ class ObjectRangeSplitterNode : public rclcpp::Node
float spilt_range_;
};

} // namespace object_range_splitter
} // namespace autoware::object_range_splitter

#endif // OBJECT_RANGE_SPLITTER__NODE_HPP_
#endif // OBJECT_RANGE_SPLITTER_NODE_HPP_
Loading